Skip to content

Commit

Permalink
fix(workflow/pr_check): wrong join() for init failures
Browse files Browse the repository at this point in the history
  • Loading branch information
alex3236 committed Feb 1, 2025
1 parent 687b0df commit 9d7c1e0
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions .github/workflows/scripts/utilities.py
Original file line number Diff line number Diff line change
Expand Up @@ -183,6 +183,7 @@ def report_init_failed(failures: dict[str, list[str]]):
> [!CAUTION]
{message}
'''
for plugin_id, messages in failures.items():
if any(re.match("Initialize plugin .+ failed", msg) for msg in messages):
Expand Down Expand Up @@ -323,12 +324,12 @@ def report_all(plugin_list: PluginList, action_list: ActionList, removed_list: l
else:
plugins = sorted(
[(plugin, action_list.plugins.get(plugin.id)) for plugin in plugin_list],
key=lambda x: x[1].value
key=lambda x: x[1].value # sort by tag
)
modified_report = '\n'.join(report_plugin(*plugin) for plugin in plugins)

removed_report = '\n'.join(report_removed(plugin) for plugin in removed_list)

init_failed_report = '\n'.join(report_init_failed(reporter.failures))
init_failed_report = report_init_failed(reporter.failures)

return header + modified_report + removed_report + init_failed_report

0 comments on commit 9d7c1e0

Please sign in to comment.