Skip to content
This repository has been archived by the owner on Sep 6, 2019. It is now read-only.

Unable batch enable on-demand #1697

Closed
vanowm opened this issue Jun 2, 2014 · 13 comments
Closed

Unable batch enable on-demand #1697

vanowm opened this issue Jun 2, 2014 · 13 comments
Labels

Comments

@vanowm
Copy link

vanowm commented Jun 2, 2014

Hello.

I can't find a way enable on-demand restrictions for all apps.

I've set template to restrict everything and enabled on-demand in it (the global on-demand setting is enabled by default too), then used toggle restrictions to apply that template. The restrictions from the template applied, but no on-demand.

Also I've tried import previously backed up settings and no on-demand were restored either.

Any installed new apps get the template just fine including the on-demand.

@M66B
Copy link
Owner

M66B commented Jun 2, 2014

You need to enable 'restrict dangerous' in the main settings for this. Please be careful not to get in a on demand "hell".

@M66B M66B added the question label Jun 2, 2014
@M66B M66B closed this as completed Jun 2, 2014
@vanowm
Copy link
Author

vanowm commented Jun 2, 2014

Sorry, but what does "restrict dangerous" has anything to do with on-demand settings?

@M66B
Copy link
Owner

M66B commented Jun 2, 2014

What you want to do is dangerous and intented only for expert users, hence my comment to be careful.

@vanowm
Copy link
Author

vanowm commented Jun 2, 2014

I think we are not understanding each other.
See, I set in the template to enable on-demand, regardless how dangerous this is or not, it should be applied when I use that template, at least this is how I expect it as a user, right?. Otherwise what's the point having a template which is being ignored when used? Perhaps a friendly warning would suffice instead of simply ignoring user's settings.
If you believe the on-demand is dangerous (for whatever reason) then perhaps it should not be in the template settings until "restrict dangerous" is enabled, or perhaps the "on-demand" global settings should not exist at all or be at least under "expert" instead and not enabled by default?
And finally, whats the point of ability exporting settings when you can't fully import them?

@M66B
Copy link
Owner

M66B commented Jun 2, 2014

To apply a template with on demand settings, on demand restricting needs to be enabled for the application(s) first. For safety reasons on demand restricting is by default off for existing applications. This is for the best interest of everybody.

I don't see what importing settings has to do with this.

M66B pushed a commit that referenced this issue Jun 2, 2014
@M66B
Copy link
Owner

M66B commented Jun 2, 2014

Next version will show these batch operations by default.
There are too many questions about this IMHO.
Hopefully everybody understands the red background color.

@vanowm
Copy link
Author

vanowm commented Jun 2, 2014

Ok, the default automatic "all allowed" for already installed apps is understandable, makes sense, it's fine. It should avoid any issues after user installed xprivacy, cool.
Now, what do a user do to enable on-demand for all/some existing apps? - open each app individually and set it manually there?

What about import settings that they exported before installing this rom? should it work? - yes, but it doesn't either for on-demand settings.

My understanding of "dangerous" permissions is they should not be restrict by default, fine, but I fail to see any kind of connection between "dangerous" and on-demain for non-"dangerous"-only permissions...

M66B pushed a commit that referenced this issue Jun 2, 2014
@M66B
Copy link
Owner

M66B commented Jun 2, 2014

Try to enabled on demand restricting for all applications and you'll see why this is dangerous.
I could easily bring your device down.

Import settings will work, I don't see how this is related to this.

@an0n981
Copy link
Contributor

an0n981 commented Jun 2, 2014

If you import settings including onDemand onto a new rom from an export where 'restrict dangerous' was checked, all your onDemand settings will also be imported.

If you enable onDemand for all your apps at once, have fun with the after the next reboot

@M66B
Copy link
Owner

M66B commented Jun 2, 2014

@an0n981
Copy link
Contributor

an0n981 commented Jun 2, 2014

This change has made my app overview very ugly https://mega.co.nz/#!Z8Ai2LbC!jjVo0sAxVA9KXwB2gajEx8d0jQ7TXUOIJVc_vAv9lyI

@M66B
Copy link
Owner

M66B commented Jun 2, 2014

Yes, I know.
I am not sure what to do here.
I could remove the reddish background color or I could hide the checkbox again.
Or maybe everybody has to get used to this.

@vanowm
Copy link
Author

vanowm commented Jun 4, 2014

Ok, I see your point now. Batch on-demand could be a bad thing.
Maybe template settings should have a little note about this, aka on-demain will only be applied to apps that already have on-demand activated? As a user I see a setting and expecting it's being used when applying template ;)

And I just learned that the backup file I was importing doesn't import the on-demand per app settings at all, however the backup file from my other phone imports on-demand settings just fine. I'm not sure what XP version I had when did export settings on this phone, so perhaps it wasn't up-to date.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants