Skip to content
This repository has been archived by the owner on Sep 6, 2019. It is now read-only.

Issue with Import/Export, restriction.values #1508

Closed
an0n981 opened this issue Mar 6, 2014 · 9 comments
Closed

Issue with Import/Export, restriction.values #1508

an0n981 opened this issue Mar 6, 2014 · 9 comments
Labels

Comments

@an0n981
Copy link
Contributor

an0n981 commented Mar 6, 2014

I came across the issue because after an import I was being asked onDemand questions that I was previously not being asked.
I have documented the issue using AFWall as an expample. I exported settings for AFWall, then cleared and re-imported.

Here a screenshot of the AFWall settings before exporting: https://mega.co.nz/#!YtpxQAQR!wC0eMTMNZ_kFJ8jGnY48qnFpzJF34ANQGZ9g9suLeNU

Here the export file: https://mega.co.nz/#!cgZ0FT4C!rEnqjC25CP8oB6q85XOBMB58Y5E3JJyFBAVEgurEeEI

And here a screenshot after re-importing: https://mega.co.nz/#!pgBShCba!awudMFtTsHPKquHKtTZHDgk3dyHyN1dTeH90ZJgegYE

From what I can tell, the onDemand values for the storage category are not being properly imported do to the fact that all restrictions in the category are set to allow, and therefor are not being exported.

In addition I found that the values in the restriction db are not in line with what is documented here: https://github.com/M66B/XPrivacy/blob/master/src/biz/bokhorst/xprivacy/PrivacyService.java#L314
Screenshot of values with settings before export: https://mega.co.nz/#!M5QlRTSa!Rxssv8qPMzvHoXyrUV-Sr1Z2WVpzOlaHNEwYcKT_Ozk

@M66B M66B added the bug label Mar 6, 2014
M66B pushed a commit that referenced this issue Mar 6, 2014
@M66B
Copy link
Owner

M66B commented Mar 6, 2014

I have sent you a test version by e-mail.

@an0n981
Copy link
Contributor Author

an0n981 commented Mar 6, 2014

Issue still active, give me a second to upload the export file, which is now only about half the size.

@an0n981
Copy link
Contributor Author

an0n981 commented Mar 6, 2014

@M66B M66B closed this as completed in 6da6c2f Mar 6, 2014
@M66B
Copy link
Owner

M66B commented Mar 6, 2014

I have fixed and tested it, but I like to have you to check it too.

As a result of the fix the export files will be somewhat larger, since all the categories will be always exported.

@an0n981
Copy link
Contributor Author

an0n981 commented Mar 6, 2014

Of course, please provide a test version.

@an0n981
Copy link
Contributor Author

an0n981 commented Mar 6, 2014

Confirmed fixed

@an0n981
Copy link
Contributor Author

an0n981 commented Mar 6, 2014

Although the export file is even smaller

@M66B
Copy link
Owner

M66B commented Mar 6, 2014

Size does not matter ;-)
Thanks for testing!

@an0n981
Copy link
Contributor Author

an0n981 commented Mar 6, 2014

That's not what she said

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants