snakecasify app/Http/Requests #3135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ildyria
added
the
Review: medium
Codecov ReportAttention: Patch coverage is
🚀 New features to boost your workflow:
|
ildyria
force-pushed
the
rector-requests
branch
from
286c15b to
5b9e10c
Compare
ppshobi
reviewed
Mar 23, 2025
| @@ -39,7 +39,7 @@ class AddSharingRequest extends BaseApiRequest implements HasAlbumIds, HasUserId | |||
| */ | |||
| public function authorize(): bool | |||
| { | |||
| return Gate::check(AlbumPolicy::CAN_SHARE_ID, [AbstractAlbum::class, $this->albumIds]); | |||
| return Gate::check(AlbumPolicy::CAN_SHARE_ID, [AbstractAlbum::class, $this->albumIds()]); | |||
There was a problem hiding this comment.
$this->albumIds()
is this intended?
There was a problem hiding this comment.
yes. It is also provided in the trait :)
ppshobi
approved these changes
Mar 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.