Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stk 4 - Refactoring & simplify #3058

Open
wants to merge 1 commit into
base: favourite-client-side
Choose a base branch
from

Conversation

ildyria
Copy link
Member

@ildyria ildyria commented Mar 4, 2025

  • Fix search button not working in album header
  • Remove search variables from togglable (as we no longer need them: no longer external photo page)
  • Move Uploadable type to Composable instead of component.

This pull request includes several changes aimed at refactoring the codebase to remove dependencies on the TogglablesStateStore and streamline the search functionality. The most important changes include updating event emissions, modifying the search implementation, and refactoring the photoRoute function to use vue-router directly.

Event Emissions:

  • Added @open-search event emission in AlbumPanel.vue and updated the emits definition accordingly. [1] [2]

Search Functionality:

  • Replaced search_term and related properties in SearchPanel.vue with a new search model. [1] [2] [3]
  • Removed search-related properties and methods from TogglablesStateStore. [1] [2] [3]

Photo Route Refactoring:

  • Updated usePhotoRoute and related invocations to use vue-router directly instead of TogglablesStateStore. [1] [2] [3] [4] [5]

Code Clean-up:

  • Moved Uploadable type definition from UploadPanel.vue to uploadEvents.ts and updated imports accordingly. [1] [2] [3]

Album and Search Views:

  • Updated Album.vue and Search.vue to remove dependencies on TogglablesStateStore for search functionality and route handling. [1] [2] [3] [4] [5]

@ildyria ildyria requested a review from a team as a code owner March 4, 2025 21:02
@ildyria ildyria added the Review: easy Easy review expected: probably just need a quick to go through. label Mar 4, 2025
Copy link

codecov bot commented Mar 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.44%. Comparing base (02d727a) to head (b4b1db7).

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ildyria ildyria changed the title Refactoring & simplify Stk 4 - Refactoring & simplify Mar 5, 2025
@ildyria ildyria force-pushed the refactoring-photo-route branch from e330a86 to b6e93c2 Compare March 10, 2025 11:39
@ildyria ildyria force-pushed the favourite-client-side branch from 7ad3073 to 24f33b1 Compare March 10, 2025 11:59
@ildyria ildyria force-pushed the refactoring-photo-route branch from b6e93c2 to ce8ce07 Compare March 10, 2025 11:59
@ildyria ildyria force-pushed the favourite-client-side branch from 24f33b1 to a151bd3 Compare March 11, 2025 12:56
@ildyria ildyria force-pushed the refactoring-photo-route branch from ce8ce07 to 63f35ab Compare March 11, 2025 12:56
@ildyria ildyria force-pushed the refactoring-photo-route branch from 63f35ab to b4b1db7 Compare March 19, 2025 22:38
@ildyria ildyria force-pushed the favourite-client-side branch from a151bd3 to 02d727a Compare March 19, 2025 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Review: easy Easy review expected: probably just need a quick to go through.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant