Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stk 1 - Refactor Album page into 2 components: display - actions #3045

Merged
merged 4 commits into from
Mar 23, 2025

Conversation

ildyria
Copy link
Member

@ildyria ildyria commented Feb 26, 2025

  • Separate the display logic into a AlbumPanel.vue (unfortunately still need to contains the context menu)
  • Add modals states to the togglable pinia store to avoid having to deal with events.
  • Add index of selections to togglable pinia store to share the info to the action modals.
  • Extract the unlock modal from the AlbumPanel.
  • Extract the consent overlay from the AlbumPanel.

This pull request introduces several significant changes to the gallery module, focusing on improving the user interface and state management. The most important changes include the addition of a new album panel template, updates to the sensitive content warning component, and enhancements to the modal state management.

User Interface Improvements:

State Management Enhancements:

Code Simplification:

@ildyria ildyria requested a review from a team as a code owner February 26, 2025 10:00
@ildyria ildyria added the Review: medium Medium review expected: not many files, some attention to details required. label Feb 26, 2025
@ildyria ildyria force-pushed the album-panel-display-from-logic branch 2 times, most recently from b5753f9 to 5514693 Compare February 28, 2025 15:11
Copy link

codecov bot commented Feb 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.42%. Comparing base (a1ba2bb) to head (5fac12a).
Report is 3 commits behind head on master.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Base automatically changed from refactor-ui to master March 1, 2025 11:46
@ildyria ildyria force-pushed the album-panel-display-from-logic branch from 5514693 to 6a67609 Compare March 1, 2025 11:49
@ildyria ildyria changed the title Refactor Album page into 2 components: display - actions Stacked 1 - Refactor Album page into 2 components: display - actions Mar 5, 2025
@ildyria ildyria changed the title Stacked 1 - Refactor Album page into 2 components: display - actions Stk 1 - Refactor Album page into 2 components: display - actions Mar 5, 2025
@ildyria ildyria force-pushed the album-panel-display-from-logic branch 2 times, most recently from d660978 to 3197811 Compare March 11, 2025 12:56
@ildyria ildyria force-pushed the album-panel-display-from-logic branch from 3197811 to d70dd01 Compare March 19, 2025 22:39
@ildyria ildyria merged commit c901f70 into master Mar 23, 2025
54 checks passed
@ildyria ildyria deleted the album-panel-display-from-logic branch March 23, 2025 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Review: medium Medium review expected: not many files, some attention to details required.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants