Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.3.0 #226

Merged
merged 3 commits into from
Feb 23, 2025
Merged

Release 0.3.0 #226

merged 3 commits into from
Feb 23, 2025

Conversation

jlaehne
Copy link
Contributor

@jlaehne jlaehne commented Feb 21, 2025

Release new version 0.3.0 following releasing guide

Progress of the PR

@jlaehne jlaehne added this to the v0.3 milestone Feb 21, 2025
@jlaehne jlaehne merged commit d646367 into LumiSpy:main Feb 23, 2025
21 checks passed
@jlaehne jlaehne deleted the release_v0.3.0 branch February 23, 2025 22:18
@jlaehne
Copy link
Contributor Author

jlaehne commented Feb 23, 2025

DOI assignment failed in the new setup that was copied from the other extensions.
@ericpre do you have some tips what might be configered wrongly? I did the linking at zenodo only after the release, but then edited the release and managed that zenodo tried to create a doi, but failed with "errors": "401 Bad credentials".
@jordiferrero is there a kind of owner/administrator status at zenodo for the package that you could activate for me?

@jlaehne
Copy link
Contributor Author

jlaehne commented Feb 24, 2025

Something went wrong on the version setting with setuptools-scm

After updating with conda to v0.3.0, it outputs:

>>> import lumispy as lum
>>> lum.__version__                                                             
'0.0.0'

Edit:

The dev branch actually also is wrong and still states:

lumispy-0.2.3.dev

while in pyproject.toml it is correctly updated to fallback_version = "0.4.dev0"

@ericpre
Copy link
Contributor

ericpre commented Feb 24, 2025

Just tried pip install lumispy in a new environment and it works fine, I get the correct version (0.3.0).
I suspect that you are importing from a local source and not the version installed in site-packages because it seems to go through the code path using setuptools_scm.

To get the correct version when running from a version controlled source, you need the latest tag, because setuptools_scm uses the tags to build the dev version.

@jlaehne
Copy link
Contributor Author

jlaehne commented Feb 24, 2025

I confirmed with a colleague having a clean conda environment and no dev versions on the PC that the conda install indeed prints 0.0.0 as version, when 0.3.0 is installed.

(the other part indeed is due to my existing local installation).

@ericpre
Copy link
Contributor

ericpre commented Feb 24, 2025

In my comment above, this was with the package on pypi.org. With the conda-forge package, I can reproduce the issue and it is fixed in conda-forge/lumispy-feedstock#9.

@ericpre
Copy link
Contributor

ericpre commented Feb 24, 2025

DOI assignment failed in the new setup that was copied from the other extensions. @ericpre do you have some tips what might be configered wrongly? I did the linking at zenodo only after the release, but then edited the release and managed that zenodo tried to create a doi, but failed with "errors": "401 Bad credentials".

Zenodo will create a DOI when a Github release is created (see for example: https://docs.github.com/en/repositories/archiving-a-github-repository/referencing-and-citing-content). Changing the workflow itself shouldn't affect this process.
Could it be this "bad credentials" error is related to an expired token or something similar.

@jordiferrero is there a kind of owner/administrator status at zenodo for the package that you could activate for me?

I suspect the required permission to be able to do that are on github. Could it be the "third-party application access policy" setting at the organisation level?. On my zenodo account, I can't enable/disable the lumispy one (but in comparison, I can for exspy):
image

@jlaehne
Copy link
Contributor Author

jlaehne commented Feb 24, 2025

I suspect the required permission to be able to do that are on github. Could it be the "third-party application access policy" setting at the organisation level?. On my zenodo account, I can't enable/disable the lumispy one (but in comparison, I can for exspy):

Thanks @ericpre for your help with both issues. I was able to enable LumiSpy on Zenodo, but I realize that @jordiferrero is the only one currently with permissions on the organization level to check the access policy.

@jlaehne
Copy link
Contributor Author

jlaehne commented Feb 25, 2025

In my comment above, this was with the package on pypi.org. With the conda-forge package, I can reproduce the issue and it is fixed in conda-forge/lumispy-feedstock#9.

Thanks, it fixed the version issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants