-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 0.3.0 #226
Release 0.3.0 #226
Conversation
5cd72bd
to
aab840d
Compare
aab840d
to
ef48fb7
Compare
DOI assignment failed in the new setup that was copied from the other extensions. |
Something went wrong on the version setting with After updating with conda to v0.3.0, it outputs:
Edit: The dev branch actually also is wrong and still states:
while in |
Just tried To get the correct version when running from a version controlled source, you need the latest tag, because |
I confirmed with a colleague having a clean conda environment and no dev versions on the PC that the conda install indeed prints (the other part indeed is due to my existing local installation). |
In my comment above, this was with the package on pypi.org. With the conda-forge package, I can reproduce the issue and it is fixed in conda-forge/lumispy-feedstock#9. |
Zenodo will create a DOI when a Github release is created (see for example: https://docs.github.com/en/repositories/archiving-a-github-repository/referencing-and-citing-content). Changing the workflow itself shouldn't affect this process.
I suspect the required permission to be able to do that are on github. Could it be the "third-party application access policy" setting at the organisation level?. On my zenodo account, I can't enable/disable the lumispy one (but in comparison, I can for exspy): |
Thanks @ericpre for your help with both issues. I was able to enable LumiSpy on Zenodo, but I realize that @jordiferrero is the only one currently with permissions on the organization level to check the access policy. |
Thanks, it fixed the version issue. |
Release new version 0.3.0 following releasing guide
Progress of the PR