Justafish/issue 204 acquia integration v3

[beto-aveiga]

• Updates the branch with main
• Add a workaround for applying composer configurations from DDEV
  • Similar previous work here https://github.com/Lullabot/drainpipe/pull/729/files#diff-35458453f942bb563be9546b6d08af7e8a167fb25d3c1e8bcbef348c981c0063R50-R58

[beto-aveiga]

The tests are passing, but yesterday, I noticed that the configuration is not being imported.
I wonder if this is related to code-switching needing a container replacement when the code is switched, and we are running configuration imports too early.
By the way, I'm cloning from PROD to DEV. PROD works as expected.

@mrdavidburns

[mrdavidburns]

@beto-aveiga I notice you have a lot of Github Action workflows deleted in this pull request. Was that to save time while testing?

What's the intent of this pull request? Will we cherry-pick the important things to keep like:

• .github/workflows/TestAcquia.yml
• scaffold/github/actions/acquia/clone-env/action.yml
• scaffold/github/actions/acquia/deploy/action.yml

And put those into #740

[beto-aveiga]

@beto-aveiga I notice you have a lot of Github Action workflows deleted in this pull request. Was that to save time while testing?

Absolutely. I will restore them when there is no need for more code.

What's the intent of this pull request? Will we cherry-pick the important things to keep like:

Make .github/workflows/TestAcquia.yml to pass and ensure the deployment works in the DEV environment where we are deploying. I'm preserving the original test structure that @justafish wrote.

@mrdavidburns

[beto-aveiga]

At scaffold/github/actions/acquia/clone-env/action.yml, we run:

        drainpipe_exec "acli env:mirror --no-config --no-interaction ${{ inputs.source-environment }} ${{ inputs.target-environment }}"

This is likely an async command, so it will run after it returns the control to our deployment script. If we immediately run configuration imports, those configuration imports will be lost because our application's container(s) will be replaced. I will check if this is true by looking at the deploy workflow and the Acquia activity feed.

@mrdavidburns

[beto-aveiga]

Regarding my previous comment...
I re-ran the deployment process and verified that after our deploy workflow test had ended, the Acquia code switch was still running. That means that the code switch was still in progress while we were running the configuration updates.

In other words, after we ran acquia/push, we ran acquia/update, but acquia/push invoked acli api:environments:code-switch, which happens asynchronously and takes a few minutes.

So, between acquia/push and acquia/update we need an something to way for the code switch to complete, otherwise our config import changes will be lost.

[mrdavidburns]

@beto-aveiga Would this work?
https://docs.acquia.com/acquia-cloud-platform/add-ons/acquia-cli/commands/app:task-wait

[beto-aveiga]

I love that solution. Thanks. @mrdavidburns !

I was already asking ChatGPT, and it gave me a different route.
https://chatgpt.com/share/67a0f0b2-fe3c-8004-b414-df645e3d24e0

But I will first try yours because it looks self-explanatory.

[beto-aveiga]

@mrdavidburns I was reading the code:switch documentation.
https://docs.acquia.com/acquia-cloud-platform/add-ons/acquia-cli/commands/api:environments:code-switch

And I noticed an important parameter:
--task-wait

I will try this first, as it doesn't require more complexity, and our line to run the code switch is already complex.

drainpipe_exec "acli api:environments:code-switch ${{ inputs.environment }} \"$BRANCH\""

[beto-aveiga]

Github status says everything is okay but workflows are not running 🤔

[beto-aveiga]

Good!
So far, it's working as expected. :)

[beto-aveiga]

Taking forever... I checked Acquia UI, also taking forever.

[beto-aveiga]

Re-running it. I don't know why the same actions took forever to complete. The only thing I added was --task-wait

[beto-aveiga]

Now that it works, the next step is to try to make a deployment to DEV with an actual site repository on Acquia.
Then, if that works as expected, finish this PR by restoring files and cleaning the code.