sum_concurrent.go

package sum

import (
	"bytes"
	"fmt"
	"io"
	"io/ioutil"
	"os"
	"sync"
	"sync/atomic"

	"github.com/efficientgo/core/errcapture"
	"github.com/efficientgo/core/errors"
)

// ConcurrentSum1 performs sum concurrently. A lot slower than ConcurrentSum3. An example of pessimisation.
// Read more in "Efficient Go"; Example 10-10.
func ConcurrentSum1(fileName string) (ret int64, _ error) {
	b, err := ioutil.ReadFile(fileName)
	if err != nil {
		return 0, err
	}

	var wg sync.WaitGroup
	var last int
	for i := 0; i < len(b); i++ {
		if b[i] != '\n' {
			continue
		}

		wg.Add(1)
		go func(line []byte) { // Creation of goroutine turns to be mem intensive on scale! (on top of time)
			defer wg.Done()
			num, err := ParseInt(line)
			if err != nil {
				// TODO(bwplotka): Return err using other channel.
				return
			}
			atomic.AddInt64(&ret, num)
		}(b[last:i])
		last = i + 1
	}
	wg.Wait()
	return ret, nil
}

// ConcurrentSum2 performs sum concurrently. A lot slower than ConcurrentSum3. An example of pessimisation.
// Read more in "Efficient Go"; Example 10-11.
func ConcurrentSum2(fileName string, workers int) (ret int64, _ error) {
	b, err := ioutil.ReadFile(fileName)
	if err != nil {
		return 0, err
	}

	var (
		wg     = sync.WaitGroup{}
		workCh = make(chan []byte, workers)
	)

	wg.Add(workers + 1)
	go func() {
		var last int
		for i := 0; i < len(b); i++ {
			if b[i] != '\n' {
				continue
			}
			workCh <- b[last:i]
			last = i + 1
		}
		close(workCh)
		wg.Done()
	}()

	for i := 0; i < workers; i++ {
		go func() {
			var sum int64
			for line := range workCh { // Common mistake: for _, line := range <-workCh
				num, err := ParseInt(line)
				if err != nil {
					// TODO(bwplotka): Return err using other channel.
					continue
				}
				sum += num
			}
			atomic.AddInt64(&ret, sum)
			wg.Done()
		}()
	}
	wg.Wait()
	return ret, nil
}

// Over inline budget, but for readability it's better. Consider splitting functions if needed to get it inlinded.
//./sum_concurrent.go:11:6: cannot inline shardedRange: function too complex: cost 95 exceeds budget 80
func shardedRange(routineNumber int, bytesPerWorker int, b []byte) (int, int) {
	begin := routineNumber * bytesPerWorker
	end := begin + bytesPerWorker
	if end+bytesPerWorker > len(b) {
		end = len(b)
	}

	// Find last newline before begin and add 1. If not found (-1), it means we
	// are at the start. Otherwise, we start after last newline.
	return bytes.LastIndex(b[:begin], []byte("\n")) + 1, end
}

// ConcurrentSum3 uses coordination free sharding to perform more efficient computation.
// Read more in "Efficient Go"; Example 10-12.
func ConcurrentSum3(fileName string, workers int) (ret int64, _ error) {
	b, err := ioutil.ReadFile(fileName)
	if err != nil {
		return 0, err
	}

	var (
		bytesPerWorker = len(b) / workers
		resultCh       = make(chan int64)
	)

	for i := 0; i < workers; i++ {
		go func(i int) {
			// Coordination-free algorithm, which shards buffered file deterministically.
			begin, end := shardedRange(i, bytesPerWorker, b)

			var sum int64
			for last := begin; begin < end; begin++ {
				if b[begin] != '\n' {
					continue
				}
				num, err := ParseInt(b[last:begin])
				if err != nil {
					// TODO(bwplotka): Return err using other channel.
					continue
				}
				sum += num
				last = begin + 1
			}
			resultCh <- sum
		}(i)
	}

	for i := 0; i < workers; i++ {
		ret += <-resultCh
	}
	close(resultCh)
	return ret, nil
}

func shardedRangeFromReaderAt(routineNumber int, bytesPerWorker int, size int, f io.ReaderAt) (int, int) {
	begin := routineNumber * bytesPerWorker
	end := begin + bytesPerWorker
	if end+bytesPerWorker > size {
		end = size
	}

	if begin == 0 {
		return begin, end
	}

	const maxNumSize = 10
	buf := make([]byte, maxNumSize)
	begin -= maxNumSize

	if _, err := f.ReadAt(buf, int64(begin)); err != nil {
		// TODO(bwplotka): Return err using other channel.
		fmt.Println(err)
		return 0, 0
	}

	for i := maxNumSize; i > 0; i-- {
		if buf[i-1] == '\n' {
			begin += i
			break
		}
	}
	return begin, end
}

// ConcurrentSum4 is like ConcurrentSum3, but it reads file in sharded way too.
// Read more in "Efficient Go"; Example 10-13.
func ConcurrentSum4(fileName string, workers int) (ret int64, _ error) {
	f, err := os.Open(fileName)
	if err != nil {
		return 0, err
	}
	defer errcapture.Do(&err, f.Close, "close file")

	s, err := f.Stat()
	if err != nil {
		return 0, err
	}

	var (
		size           = int(s.Size())
		bytesPerWorker = size / workers
		resultCh       = make(chan int64)
	)

	if bytesPerWorker < 10 {
		return 0, errors.New("can't have less bytes per goroutine than 10")
	}

	for i := 0; i < workers; i++ {
		go func(i int) {
			begin, end := shardedRangeFromReaderAt(i, bytesPerWorker, size, f)
			r := io.NewSectionReader(f, int64(begin), int64(end-begin))

			b := make([]byte, 8*1024)
			sum, err := Sum6Reader(r, b)
			if err != nil {
				// TODO(bwplotka): Return err using other channel.
				fmt.Println(err)
			}
			resultCh <- sum
		}(i)
	}

	for i := 0; i < workers; i++ {
		ret += <-resultCh
	}
	close(resultCh)
	return ret, nil
}