camera: fix unchecked NO_HEIGHT usage

[lahm86]

Resolves #1034.

Checklist

• I have read the coding conventions
• I have added a changelog entry about what my pull request accomplishes, or it is an internal change
• I have added a readme entry about my new feature or OG bug fix, or it is a different change

Description

This resolves instances where the camera Y shift could result in extremely large values when NO_HEIGHT is involved, hence resulting in the camera going out of bounds for a frame or so. We now check for this case and use the previous valid Y position of the camera. @aredfan has provided saves in the issue where there are prominent cases of this.

This doesn't fix all instances where the camera can go into walls/OOB - the other related issue is with the interpolated values, which we'll tackle separately. This PR addresses only those instances where the camera is thrown up to -32768.

[github-actions]

Download the built assets for this pull request:

• TR1X-4.8.3-67-g2b9c72a-linux.zip
• TR1X-4.8.3-67-g2b9c72a-win.zip
• TR1X-4.8.3-67-g2b9c72a-win-installer.zip
• TR2X-0.9.2-64-g2b9c72a-linux.zip
• TR2X-0.9.2-64-g2b9c72a-win.zip

[lahm86]

Slight logic re-organisation, so we're testing for no height first to still allow a LOS check. This gives a slightly smoother shift in some cases e.g. in the save below if you jump straight up
save_tr1_03.zip

[aredfan]

I can confirm the scenarios from the issue are fixed. Also City of Khamoon and Wreck of the Maria Doria, room 52 both LGTM.

It's fantastic to see this bugfix introduced to TRX. Thank you again. 👍

[walkawayy]

Slight logic re-organisation, so we're testing for no height first to still allow a LOS check. This gives a slightly smoother shift in some cases e.g. in the save below if you jump straight up save_tr1_03.zip

I can't load the save for some reason due to the item count.

game/savegame/savegame_bson.c 474 M_LoadItems Malformed save: expected 93 items, got 94
game/game_flow/sequencer_events.c 155 M_HandlePlayLevel Failed to load save file!
libtrx/game/game_flow/sequencer.c 39 M_RunEvent event type=loop_game(1) data=0xa finished, result: action=exit_to_title, param=0
game/shell.c 197 Shell_Main action=exit_to_title param=0
libtrx/game/savegame.c 15 Savegame_UnbindSlot Resetting the save slot
game/level.c 521 Level_Initialise num=0 (data/title.phd)
game/savegame/savegame.c 169 Savegame_GetCurrentInfo Warning: unable to get resume info for level 0 (type=title)

[aredfan]

I can't load the save for some reason due to the item count.

I ran into the same issue, I figured I needed to enable the Restore PS1 enemies option.

[lahm86]

Ah, sorry, I forget the mummy can cause this issue. Thanks.