Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

output: move texture consts/types to TRX #2389

Merged
merged 2 commits into from
Jan 25, 2025

Conversation

lahm86
Copy link
Collaborator

@lahm86 lahm86 commented Jan 25, 2025

Checklist

  • I have read the coding conventions
  • I have added a changelog entry about what my pull request accomplishes, or it is an internal change
  • I have added a readme entry about my new feature or OG bug fix, or it is a different change

Description

A modest start ahead of packing/injection work - this simply moves some consts and types to TRX. Still planning the remainder of this, but the path isn't clear yet in my head.

This renames the various texture page constants in TR1 to match TR2,
and moves the definitions to TRX.
This removes the union in RGB structs in TR2 to match TR1, and shifts
the definitions themselves to TRX.
@lahm86 lahm86 added Internal The invisible stuff TR2 TR1 labels Jan 25, 2025
@lahm86 lahm86 self-assigned this Jan 25, 2025
@lahm86 lahm86 requested review from a team as code owners January 25, 2025 21:19
@lahm86 lahm86 requested review from rr-, walkawayy and aredfan and removed request for a team January 25, 2025 21:19
@lahm86 lahm86 merged commit 4a4f4ef into LostArtefacts:develop Jan 25, 2025
8 checks passed
@lahm86 lahm86 deleted the trx-texture-consts-types branch January 25, 2025 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Internal The invisible stuff TR1 TR2
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants