Game flow rework (pt 7) #2388
Merged
Game flow rework (pt 7) #2388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rr-
requested review from
lahm86,
walkawayy and
aredfan
and removed request for
a team
|
The end of level stats don't show after the Qualopec cutscene. They appear fine after Tihocan and Atlantis cutscenes though. |
|
Sorry, another issue is if you save in Qualopec, reload, then finish the level, the cutscene doesn't show (but the stats do). |
|
Thanks @lahm86 fixed both issues. |
aredfan
approved these changes
Jan 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
This moves the cutscenes in TR1 to its own key. There are several things that needed to be done to make this work:
GFS_EXIT_TO_CUTSCENEGFS_PLAY_CUTSCENEfrom TR2GFL_DUMMYso that we don't have to change the level count in the main level list (needed for the legacy saves), and at the same time we don't need to provide all the usual information such as paths and whatnot for those levels. I'll later try to remove this type altogether with some heuristics in the savegame reader, but not now.