rooms: use flip status flag for finding rooms #2373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This introduces a flip status flag on rooms so that we can avoid yielding rooms that are not in the correct state when finding one by position. Resolves LostArtefacts#2362. Resolves LostArtefacts#2370.
lahm86
requested review from
rr-,
walkawayy and
aredfan
and removed request for
a team
|
Download the built assets for this pull request: |
rr-
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2362.
Resolves #2370.
Checklist
Description
This introduces a flip status flag on rooms so that we can avoid yielding rooms that are not in the correct state when finding one by position.
It'd be good to test saving/loading in different flip states, and while in photo mode, issue
/flipin a flipmap area to ensure everything looks good.I may follow this up soon with getting rooms handled more commonly in TRX for such things as main reading/loading and handling flipmaps to reduce some duplication.