Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tr2/lara/misc: fix joint position calculation #2366

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

lahm86
Copy link
Collaborator

@lahm86 lahm86 commented Jan 23, 2025

Resolves #2359.

Checklist

  • I have read the coding conventions
  • I have added a changelog entry about what my pull request accomplishes, or it is an internal change
  • I have added a readme entry about my new feature or OG bug fix, or it is a different change

Description

This restores the original bone lookup for when Lara is holding a flare on an interpolated frame. This doesn't appear logical as it differs from the non-interpolated routine, but this matches the original bone indexing we had below before the refactoring work.

void Lara_GetJointAbsPosition_I(

This restores the original bone lookup for when Lara is holding a flare
on an interpolated frame.

Resolves LostArtefacts#2359.
@lahm86 lahm86 added TRX bug A bug with TRX Unreleased Applies to things that aren't in a stable release. TR2 labels Jan 23, 2025
@lahm86 lahm86 self-assigned this Jan 23, 2025
@lahm86 lahm86 requested review from a team as code owners January 23, 2025 19:57
@lahm86 lahm86 requested review from rr-, walkawayy and aredfan and removed request for a team January 23, 2025 19:57
Copy link
Collaborator

@aredfan aredfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@lahm86 lahm86 merged commit b235f20 into LostArtefacts:develop Jan 23, 2025
7 checks passed
@lahm86 lahm86 deleted the issue-2359-fix-lara-joint-calc branch January 23, 2025 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TR2 TRX bug A bug with TRX Unreleased Applies to things that aren't in a stable release.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

TR2X bug: flare lighting doesn't flicker
3 participants