Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OG bug: save crystals are affected by light point if both share the same space #1514

Open
aredfan opened this issue Sep 14, 2024 · 6 comments
Labels
Data Requires injecting content / files that are not a part of the original game OG bug A bug in original game TR1

Comments

@aredfan
Copy link
Collaborator

aredfan commented Sep 14, 2024

Regression since: #1510
Saves: save_tr1_03.zip


The dev snapshot before 1510:

Before.mp4

The dev snapshot after 1510:

After.mp4

It looks like there's a lighting issue within the reflection. I suspect this bug happens because there's a light point inside the save crystal.

After going through all the OG levels on trview, I only found 2 save crystals with a light point inside.

Colosseum, room 0.
Screenshot 1
The Cistern, room 16.
Screenshot 2

@aredfan aredfan added TRX bug A bug with TRX Unreleased Applies to things that aren't in a stable release. labels Sep 14, 2024
@lahm86
Copy link
Collaborator

lahm86 commented Sep 14, 2024

I think this is an OG bug? If you check in the current release you can see the lighting performs the same way on the flat crystal. So the current build is more in line with OG than the dev snapshot before 1510, I would say.
You get a similar sort of uneven lighting if you consume the crystal and just have Lara stand in the spot and turn around.
Data issue ultimately.

@rr-
Copy link
Collaborator

rr- commented Sep 14, 2024

I agree with Lahm's analysis – it's a data issue with the light placement.

@rr- rr- added Data Requires injecting content / files that are not a part of the original game OG bug A bug in original game and removed Unreleased Applies to things that aren't in a stable release. TRX bug A bug with TRX labels Sep 14, 2024
@lahm86
Copy link
Collaborator

lahm86 commented Sep 14, 2024

We could inject a Y shift for the lights, but it would likely produce subtle differences on the room's overall lighting.

@Richard-L
Copy link
Collaborator

Tried reproducing it on PS1 (as to me that is "OG"). If it should help here's a clip. Looks normal.

2024-09-14.13-53-17.mp4

@aredfan
Copy link
Collaborator Author

aredfan commented Sep 14, 2024

I'm ok with shifting the light points if it can be done in a subtle and vanilla-friendly way. At least it's a rare bug, all things considered.

@aredfan aredfan changed the title TR1X bug: save crystals are affected by light point if both share the same space OG bug: save crystals are affected by light point if both share the same space Sep 14, 2024
@rr-
Copy link
Collaborator

rr- commented Sep 14, 2024

Ideally we should be able to match PS1 without changing the data.

@rr- rr- added the TR1 label Oct 3, 2024
@rr- rr- removed the Priority: low label Oct 3, 2024
@rr- rr- moved this to Backlog in TRX Dev tracker Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Data Requires injecting content / files that are not a part of the original game OG bug A bug in original game TR1
Projects
Status: Backlog
Development

No branches or pull requests

4 participants