-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OG bug: save crystals are affected by light point if both share the same space #1514
Comments
I think this is an OG bug? If you check in the current release you can see the lighting performs the same way on the flat crystal. So the current build is more in line with OG than the dev snapshot before 1510, I would say. |
I agree with Lahm's analysis – it's a data issue with the light placement. |
We could inject a Y shift for the lights, but it would likely produce subtle differences on the room's overall lighting. |
Tried reproducing it on PS1 (as to me that is "OG"). If it should help here's a clip. Looks normal. 2024-09-14.13-53-17.mp4 |
I'm ok with shifting the light points if it can be done in a subtle and vanilla-friendly way. At least it's a rare bug, all things considered. |
Ideally we should be able to match PS1 without changing the data. |
Regression since: #1510
Saves: save_tr1_03.zip
The dev snapshot before 1510:
Before.mp4
The dev snapshot after 1510:
After.mp4
It looks like there's a lighting issue within the reflection. I suspect this bug happens because there's a light point inside the save crystal.
After going through all the OG levels on trview, I only found 2 save crystals with a light point inside.
Colosseum, room 0.
![Screenshot 1](https://private-user-images.githubusercontent.com/94776985/367510472-db4a7c10-6795-437a-8b40-65d293ba5faa.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1OTAxNTYsIm5iZiI6MTczOTU4OTg1NiwicGF0aCI6Ii85NDc3Njk4NS8zNjc1MTA0NzItZGI0YTdjMTAtNjc5NS00MzdhLThiNDAtNjVkMjkzYmE1ZmFhLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE1VDAzMjQxNlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTdmOWUyMzA3YjhlNDI1NTY4OTYyN2U3ZjdhODEzODRlZmVhMzQ0NmE4MDY1NTVlNGE3NjQ4MTE0ODE5OWExMjUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.bftjZs2fzueAnPAYaEUWz5yZyhYT_xGS6vC_1d_lIC8)
![Screenshot 2](https://private-user-images.githubusercontent.com/94776985/367510477-2a5d505e-2183-450e-ad78-30c7b720b01a.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1OTAxNTYsIm5iZiI6MTczOTU4OTg1NiwicGF0aCI6Ii85NDc3Njk4NS8zNjc1MTA0NzctMmE1ZDUwNWUtMjE4My00NTBlLWFkNzgtMzBjN2I3MjBiMDFhLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE1VDAzMjQxNlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTNlZGI4NTA3MzM0MmFhMmZmNDcxMTc4OTYxZjBjNmVlNzZmZWRkZWNiM2FhNTA0NWE0M2YyNGNlOTVjMmNhMzkmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.8fddiTOaUnm6jRxBYj4eIQMlOLN6dsViTwuKSDWD1s4)
The Cistern, room 16.
The text was updated successfully, but these errors were encountered: