General housekeeping #791
Merged
General housekeeping #791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves some vulnerability warnings from older dependencies.
This is not an issue IMO and touches practically every file in the solution. The alternative would result in an overhaul of all usings.
Fixes warnings about lamba compilation time.
chreden
approved these changes
Nov 17, 2024
rr-
approved these changes
Nov 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
Some general housekeeping, mainly to remove VS warning/message noise. Some packages had vulnerabilities too, and there was a stale reference to
System.Drawing.Commonin the core project.The message suppression re namespace/folder structure mismatch is not ideal, but I don't see this as an issue. The alternative is updating practically every file in the solution, both in terms of its namespace and the
usinglist, so that is not something I want to have to do.GH actions should build a bit more quickly now too, as we only need to target the view project rather than build everything. The other projects are still tested.