Add classic/remastered environment tags #683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lahm86
force-pushed
the
issue-614-trr-environment-tags
branch
from
b2c96e5 to
05ba4ef
Compare
rr-
approved these changes
May 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #614.
Checklist
Description
Although general environment randomization isn't going to be possible (at least yet) there are still some functions that always run, such as to tweak areas for specific secrets or at the beginning of HSH to change how things are triggered. This change makes classic-only and remastered-only tags available so we can distinguish in the JSON and ultimately ensure we're not doing anything illegal in TRR.