Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make package installable through pip #28

Open
yanone opened this issue Jan 23, 2023 · 0 comments
Open

Make package installable through pip #28

yanone opened this issue Jan 23, 2023 · 0 comments

Comments

@yanone
Copy link

yanone commented Jan 23, 2023

Hello,

it would be great if the package could be installable via pip, either hosted on PyPI (voluntary) or at least from the repo directly. It would need a setup.py that has all the necessary information for pip.

Installation example via PyPI:
pip install hello_loopring

Installation example via repo:
pip install git+https://github.com/Loopring/hello_loopring

This way it could automatically be used as a dependency in other tools, such as trading frameworks.

Much of the code is currently unusable as-is.
Example 1: the REST API Endpoint that's hard-coded into the client isn't even a real domain: https://github.com/Loopring/hello_loopring/blob/loopring-v3/sdk/loopring_v3_client.py#L25
Example 2: the command line explorer isn't even usable as-is, because it can't import sdk from that folder structure.

Anyone wanting to use the code would need to download and tweak it. That's sad, when it can be made usable with hopefully just minor tweaks.

I could submit a PR if you like.

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant