Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(video): log correct max bitrate value #3654

Closed
wants to merge 1 commit into from

Conversation

FrogTheFrog
Copy link
Collaborator

Description

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

@FrogTheFrog FrogTheFrog marked this pull request as draft February 10, 2025 19:54
@ReenigneArcher ReenigneArcher mentioned this pull request Feb 10, 2025
10 tasks
Copy link

codecov bot commented Feb 10, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 11.61%. Comparing base (4f62944) to head (63cf167).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
src/video.cpp 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3654   +/-   ##
=======================================
  Coverage   11.61%   11.61%           
=======================================
  Files          92       92           
  Lines       17335    17335           
  Branches     8099     8099           
=======================================
  Hits         2013     2013           
  Misses      12832    12832           
  Partials     2490     2490           
Flag Coverage Δ
Linux 11.28% <0.00%> (ø)
Windows 13.01% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/video.cpp 21.44% <0.00%> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant