-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend session timeout #1890
Extend session timeout #1890
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not a requirement, but in our effort to improve our code documentation, would you mind adding documentation blocks for the two modified functions? https://docs.lizardbyte.dev/projects/sunshine/en/latest/source/src.html#src
Which clients were needing an extended timeout? |
I'm in the process of porting Moonlight to the 3DS. Setup and streaming are working alright with gamestream, so I'm trying to make sure it works with Sunshine too. |
Done! I'm always happy to help document |
0430f69
to
fa52ef9
Compare
@cgutman any objection on this one? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, LGTM.
Description
Use the ping timeout for the launch event's timeout value, to allow users of slower clients more time to connect.
Type of Change
.github/...
)Checklist
Branch Updates
LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.