Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend session timeout #1890

Merged
merged 4 commits into from
Dec 9, 2023

Conversation

zoeyjodon
Copy link
Contributor

Description

Use the ping timeout for the launch event's timeout value, to allow users of slower clients more time to connect.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

@CLAassistant
Copy link

CLAassistant commented Dec 4, 2023

CLA assistant check
All committers have signed the CLA.

@ReenigneArcher

This comment was marked as resolved.

@ReenigneArcher ReenigneArcher marked this pull request as draft December 4, 2023 19:16
Copy link
Member

@ReenigneArcher ReenigneArcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a requirement, but in our effort to improve our code documentation, would you mind adding documentation blocks for the two modified functions? https://docs.lizardbyte.dev/projects/sunshine/en/latest/source/src.html#src

@cgutman
Copy link
Collaborator

cgutman commented Dec 5, 2023

Which clients were needing an extended timeout?

@zoeyjodon
Copy link
Contributor Author

zoeyjodon commented Dec 5, 2023

Which clients were needing an extended timeout?

I'm in the process of porting Moonlight to the 3DS. Setup and streaming are working alright with gamestream, so I'm trying to make sure it works with Sunshine too.

@zoeyjodon
Copy link
Contributor Author

This is not a requirement, but in our effort to improve our code documentation, would you mind adding documentation blocks for the two modified functions? https://docs.lizardbyte.dev/projects/sunshine/en/latest/source/src.html#src

Done! I'm always happy to help document

@zoeyjodon zoeyjodon force-pushed the extend-session-timeout branch from 0430f69 to fa52ef9 Compare December 5, 2023 18:41
@ReenigneArcher ReenigneArcher marked this pull request as ready for review December 5, 2023 22:45
@ReenigneArcher
Copy link
Member

@cgutman any objection on this one?

Copy link
Collaborator

@cgutman cgutman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, LGTM.

@ReenigneArcher ReenigneArcher merged commit a851ef6 into LizardByte:nightly Dec 9, 2023
43 checks passed
KuleRucket pushed a commit to KuleRucket/Sunshine that referenced this pull request Jun 6, 2024
e-dong pushed a commit to e-dong/Sunshine that referenced this pull request Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants