Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sunshine assumes assets directory is relative to current directory for box art images #173

Closed
ReenigneArcher opened this issue Jun 8, 2022 · 1 comment · Fixed by #332
Assignees
Labels
fixed This issue has been fixed and will be available in the next release.

Comments

@ReenigneArcher
Copy link
Member

https://github.com/SunshineStream/Sunshine/blob/c75efd399960422f2c3c69b930f30122f147c6f1/sunshine/process.cpp#L214-L217

Something like this might work.

  std::error_code code;
  if(!std::filesystem::exists(app_image_path, code) || image_extension != ".png") {
    if(!std::filesystem::exists(SUNSHINE_ASSETS_DIR "/" app_image_path, code)) {
        return SUNSHINE_ASSETS_DIR "/box.png";
    }
  }

Update apps.json files as well:
https://github.com/SunshineStream/Sunshine/blob/e7ec6050d9a820549d556bf80e6dcb17460ee996/src_assets/linux/config/apps.json#L17
https://github.com/SunshineStream/Sunshine/blob/e7ec6050d9a820549d556bf80e6dcb17460ee996/src_assets/windows/config/apps.json#L11
"image-path":"steam.png"

@ReenigneArcher ReenigneArcher added the bug Something isn't working label Jun 8, 2022
@ReenigneArcher ReenigneArcher self-assigned this Jun 8, 2022
@ReenigneArcher ReenigneArcher mentioned this issue Aug 26, 2022
7 tasks
@ReenigneArcher ReenigneArcher added the fixed This issue has been fixed and will be available in the next release. label Oct 16, 2022
@github-actions
Copy link

This issue has been fixed and will be available in the next release.

@ReenigneArcher ReenigneArcher mentioned this issue Oct 16, 2022
5 tasks
@ReenigneArcher ReenigneArcher removed the bug Something isn't working label Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixed This issue has been fixed and will be available in the next release.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants