Merge branch 'nightly' into extend-session-timeout

LizardByte · Dec 5, 2023 · 0430f69 · 0430f69
2 parents 69d1602 + 4a2f702
commit 0430f69
Show file tree

Hide file tree

Showing 3 changed files with 33 additions and 10 deletions.
diff --git a/.github/workflows/release-notifier.yml b/.github/workflows/release-notifier.yml
@@ -15,8 +15,8 @@ on:
 jobs:
   discord:
     if: >-
-      startsWith(github.repository, 'LizardByte/') and
-      not(github.event.release.prerelease) and
+      startsWith(github.repository, 'LizardByte/') &&
+      not(github.event.release.prerelease) &&
       not(github.event.release.draft)
     runs-on: ubuntu-latest
     steps:
@@ -34,8 +34,8 @@ jobs:
 
   facebook_group:
     if: >-
-      startsWith(github.repository, 'LizardByte/') and
-      not(github.event.release.prerelease) and
+      startsWith(github.repository, 'LizardByte/') &&
+      not(github.event.release.prerelease) &&
       not(github.event.release.draft)
     runs-on: ubuntu-latest
     steps:
@@ -51,8 +51,8 @@ jobs:
 
   facebook_page:
     if: >-
-      startsWith(github.repository, 'LizardByte/') and
-      not(github.event.release.prerelease) and
+      startsWith(github.repository, 'LizardByte/') &&
+      not(github.event.release.prerelease) &&
       not(github.event.release.draft)
     runs-on: ubuntu-latest
     steps:
@@ -68,8 +68,8 @@ jobs:
 
   reddit:
     if: >-
-      startsWith(github.repository, 'LizardByte/') and
-      not(github.event.release.prerelease) and
+      startsWith(github.repository, 'LizardByte/') &&
+      not(github.event.release.prerelease) &&
       not(github.event.release.draft)
     runs-on: ubuntu-latest
     steps:
@@ -88,8 +88,8 @@ jobs:
 
   twitter:
     if: >-
-      startsWith(github.repository, 'LizardByte/') and
-      not(github.event.release.prerelease) and
+      startsWith(github.repository, 'LizardByte/') &&
+      not(github.event.release.prerelease) &&
       not(github.event.release.draft)
     runs-on: ubuntu-latest
     steps:

diff --git a/docs/source/troubleshooting/windows.rst b/docs/source/troubleshooting/windows.rst
@@ -4,3 +4,11 @@ Windows
 No gamepad detected
 -------------------
 #. Verify that you've installed `Nefarius Virtual Gamepad <https://github.com/nefarius/ViGEmBus/releases/latest>`__.
+
+Permission denied
+-----------------
+Since Sunshine runs as a service on Windows, it may not have the same level of access that your regular user account
+has. You may get permission denied errors when attempting to launch a game or application from a non system drive.
+
+You will need to modify the security permissions on your disk. Ensure that user/principal SYSTEM has full
+permissions on the disk.
diff --git a/src/platform/windows/publish.cpp b/src/platform/windows/publish.cpp
@@ -119,6 +119,21 @@ namespace platf::publish {
     instance.wPort = map_port(nvhttp::PORT_HTTP);
     instance.pszHostName = host.data();
 
+    // Setting these values ensures Windows mDNS answers comply with RFC 1035.
+    // If these are unset, Windows will send a TXT record that has zero strings,
+    // which is illegal. Setting them to a single empty value causes Windows to
+    // send a single empty string for the TXT record, which is the correct thing
+    // to do when advertising a service without any TXT strings.
+    //
+    // Most clients aren't strictly checking TXT record compliance with RFC 1035,
+    // but Apple's mDNS resolver does and rejects the entire answer if an invalid
+    // TXT record is present.
+    PWCHAR keys[] = { nullptr };
+    PWCHAR values[] = { nullptr };
+    instance.dwPropertyCount = 1;
+    instance.keys = keys;
+    instance.values = values;
+
     DNS_SERVICE_REGISTER_REQUEST req {};
     req.Version = DNS_QUERY_REQUEST_VERSION1;
     req.pQueryContext = alarm.get();