fix: coverage

LimeChain · Nov 27, 2023 · dd8b88c · dd8b88c
1 parent b83e5b2
commit dd8b88c
Show file tree

Hide file tree

Showing 5 changed files with 22 additions and 12 deletions.
diff --git a/build/runtime.wasm b/build/runtime.wasm
diff --git a/goscale b/goscale
diff --git a/primitives/types/extra.go b/primitives/types/extra.go
@@ -174,22 +174,21 @@ func generateExtraMetadata(extra SignedExtension, metadataIds map[string]int, me
 	if !ok {
 		extraMetadataId = buildMetadataTypeRecursively(extraType, metadataIds, metadataTypes, true)
 	} else {
-		extraMetadata := getExtraMetadata(extraMetadataId, metadataTypes)
-		*metadataTypes = append(*metadataTypes, extraMetadata)
+		getExtraMetadata(extraMetadataId, metadataTypes)
 	}
 
 	constructExtension(extraValue, extraMetadataId, extensions, metadataIds, metadataTypes)
 
 	return extraMetadataId
 }
 
-func getExtraMetadata(id int, metadataTypes *sc.Sequence[MetadataType]) MetadataType {
+func getExtraMetadata(id int, metadataTypes *sc.Sequence[MetadataType]) {
 	for _, t := range *metadataTypes {
 		if t.Id.ToBigInt().Int64() == int64(id) {
-			return t
+			*metadataTypes = append(*metadataTypes, t)
+			break
 		}
 	}
-	return MetadataType{}
 }
 
 // buildMetadataTypeRecursively build the metadata of the type recursively.

diff --git a/primitives/types/extra_test.go b/primitives/types/extra_test.go
@@ -117,6 +117,7 @@ var (
 var (
 	expectedH512MetadataId             = lastIndex + 1
 	expectedEd25519PublicKeyMetadataId = lastIndex + 2
+	expectedWeightId                   = lastIndex + 3
 
 	// A map that contains the ids of all additional signed complex checks
 	metadataIdsComplexAll = map[string]int{
@@ -136,6 +137,7 @@ var (
 		"H256":             metadata.TypesH256,
 		"H512":             expectedH512MetadataId,
 		"Ed25519PublicKey": expectedEd25519PublicKeyMetadataId,
+		"Weight":           expectedWeightId,
 	}
 
 	lastIndexComplexChecks = len(metadataIdsComplexAll)
@@ -183,13 +185,14 @@ var (
 		metadataSignedExtensionComplex,
 	}
 
-	tupleAdditionalSignedMetadataType = NewMetadataType(expectedTupleAdditionalSignedMetadataId, "H256U32U64H512Ed25519PublicKey",
+	tupleAdditionalSignedMetadataType = NewMetadataType(expectedTupleAdditionalSignedMetadataId, "H256U32U64H512Ed25519PublicKeyWeight",
 		NewMetadataTypeDefinitionTuple(sc.Sequence[sc.Compact]{
 			sc.ToCompact(metadata.TypesH256),
 			sc.ToCompact(metadata.PrimitiveTypesU32),
 			sc.ToCompact(metadata.PrimitiveTypesU64),
 			sc.ToCompact(expectedH512MetadataId),
-			sc.ToCompact(expectedEd25519PublicKeyMetadataId)}))
+			sc.ToCompact(expectedEd25519PublicKeyMetadataId),
+			sc.ToCompact(expectedWeightId)}))
 
 	signedExtraMdType = MetadataType{
 		Id:         sc.ToCompact(metadata.SignedExtra),
@@ -281,7 +284,8 @@ var (
 	expectedCheckEraMetadataIdSome              = lastIndexComplexChecksSome + 2
 	expectedEraMetadataIdSome                   = lastIndexComplexChecksSome + 3
 	expectedExtraCheckComplexIdSome             = lastIndexComplexChecksSome + 4
-	expectedTupleAdditionalSignedMetadataIdSome = lastIndexComplexChecksSome + 5
+	expectedWeightIdSome                        = lastIndexComplexChecksSome + 5
+	expectedTupleAdditionalSignedMetadataIdSome = lastIndexComplexChecksSome + 6
 
 	testExtraCheckEmptyMetadataTypeSome = MetadataType{
 		Id:         sc.ToCompact(expectedEmptyCheckMetadataIdSome),
@@ -313,13 +317,19 @@ var (
 		}),
 	)
 
-	tupleAdditionalSignedMetadataTypeSome = NewMetadataType(expectedTupleAdditionalSignedMetadataIdSome, "H256U32U64H512Ed25519PublicKey",
+	weightMetadataTypeSome = NewMetadataType(expectedWeightIdSome, "Weight", NewMetadataTypeDefinitionComposite(sc.Sequence[MetadataTypeDefinitionField]{
+		NewMetadataTypeDefinitionFieldWithName(metadata.PrimitiveTypesU64, "RefTime"),
+		NewMetadataTypeDefinitionFieldWithName(metadata.PrimitiveTypesU64, "ProofSize"),
+	}))
+
+	tupleAdditionalSignedMetadataTypeSome = NewMetadataType(expectedTupleAdditionalSignedMetadataIdSome, "H256U32U64H512Ed25519PublicKeyWeight",
 		NewMetadataTypeDefinitionTuple(sc.Sequence[sc.Compact]{
 			sc.ToCompact(metadata.TypesH256),
 			sc.ToCompact(metadata.PrimitiveTypesU32),
 			sc.ToCompact(metadata.PrimitiveTypesU64),
 			sc.ToCompact(metadata.TypesFixedSequence64U8),
-			sc.ToCompact(metadata.TypesFixedSequence64U8)}))
+			sc.ToCompact(metadata.TypesFixedSequence64U8),
+			sc.ToCompact(expectedWeightIdSome)}))
 
 	testExtraCheckComplexMetadataTypeSome = MetadataType{
 		Id:     sc.ToCompact(expectedExtraCheckComplexIdSome),
@@ -348,6 +358,7 @@ var (
 		eraMetadataTypeSome,
 		testExtraCheckEraMetadataTypeSome,
 		testExtraCheckComplexMetadataTypeSome,
+		weightMetadataTypeSome,
 		tupleAdditionalSignedMetadataTypeSome,
 		signedExtraMdTypeSome,
 	}

diff --git a/primitives/types/testExtraCheckComplex_test.go b/primitives/types/testExtraCheckComplex_test.go
@@ -18,7 +18,7 @@ type testExtraCheckComplex struct {
 func newtTestExtraCheckComplex() SignedExtension {
 	return &testExtraCheckComplex{
 		era:                  Era{},
-		additionalSignedData: sc.NewVaryingData(H256{}, sc.U32(0), sc.U64(0), H512{}, Ed25519PublicKey{}),
+		additionalSignedData: sc.NewVaryingData(H256{}, sc.U32(0), sc.U64(0), H512{}, Ed25519PublicKey{}, Weight{}),
 	}
 }
+3 −1		.github/workflows/test.yaml
+3 −3		README.md
+4 −4		boolean_test.go
+3 −2		codecov.yaml
+48 −2		common_test.go
+3 −3		compact.go
+14 −4		compact_test.go
+9 −9		dictionary.go
+16 −6		dictionary_test.go
+2 −2		empty_test.go
+4 −4		i128.go
+14 −4		i128_test.go
+2 −2		i16.go
+13 −3		i16_test.go
+2 −2		i32.go
+13 −3		i32_test.go
+2 −2		i64.go
+13 −3		i64_test.go
+2 −2		i8.go
+13 −3		i8_test.go
+2 −1		numeric_test.go
+4 −6		option.go
+82 −83		option_test.go
+21 −11		result.go
+56 −379		result_test.go
+8 −8		sequence.go
+127 −32		sequence_test.go
+16 −16		tuple_test.go
+14 −4		u128_test.go
+13 −3		u16_test.go
+14 −4		u32_test.go
+13 −3		u64_test.go
+3 −3		u8_test.go
+6 −6		varying_data_test.go