-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[12기] 김민혁 과제 제출합니다. #3
Open
K-Minhyeok
wants to merge
18
commits into
LikeLionHGU:main
Choose a base branch
from
K-Minhyeok:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
딱 포기하기 직전 난이도 정도로 어렵네요
그래도 하다보니까 조금씩 이해되는 것 같습니다.
그냥 계속 해보는 수밖에는 딱히 별 방법없는 것 같네요.
DTO , Domain 에서 많이 헷갈렸던 것 같고,
작은 단위 로직부터 구현하다보니 어떤 것이 어떻게 다른지 알 수 있었습니다.
깔끔하고 완벽하게 구현했다기보단
이 3개를 배우는 것에 중점을 두었습니다.