bq769x2: Add support for configuring REG0 (pre-regulator) #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
The technical reference says that one should no change voltage setting on REG 1 and REG2 if it is enabled. So the correct setting procedure seems to be:
- Ensure that REG1_EN and REG2_EN REG_0 are OFF.
- set the voltages and end REG{1,2}_EN bits as needed
- Optionally set REG0_EN.
Don't you think having both reg0_config field AND BIT(0) in enable_vregs is little bit confusing to ensure the correct sequence?
|
@vlebedev-ora Sorry for the late reply. As the voltages are currently not changed, I think it should work the way I implemented it. Do you agree? |
It seems so |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was not possible to enable the pre-regulator REG0, which is required in most cases when REG1 and REG2 are needed. In addition to that,
bq769x2_configure_voltage_regsdid not correctly update the actually configured regulators.Fixes #85