Integrate bms_ic device into bms_context #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, both the bms_ic and the bms_context had to be shared between different files, even though the bms_ic dev logically belongs to the bms_context. This commit adds a const struct device *ic_dev to the bms_context, solving the issue.
pasrom
approved these changes
Feb 6, 2024
|
Thanks for the very quick review! This was my last clean-up for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, both the
bms_icand thebms_contexthad to be shared between different files, even though thebms_icdev logically belongs to thebms_context.This commit adds a
const struct device *ic_devto thebms_context, solving the issue.