drivers: bms_ic: change return value for bms_ic_configure #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pasrom
requested changes
Feb 4, 2024
Not all BMS ICs support all CONF_ values, which made the call to bms_ic_configure fail in the generic BMS main application. With this API change it is left to the application to judge if the configuration call is considered successful or not.
martinjaeger
force-pushed
the
bms-ic-configure-return-value
branch
from
0af6e8c to
3e18d7a
Compare
pasrom
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not all BMS ICs support all
CONF_values, which made the call tobms_ic_configurefail in the generic BMS main application.With this API change it is left to the application to judge if the configuration call is considered successful or not.