Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat( /nomination/{congress}/{nominationNumber}/{ordinal}) nominee API should return introText, organization, positionTitle #267

Open
ryparker opened this issue Jul 21, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@ryparker
Copy link
Contributor

ryparker commented Jul 21, 2024

This is a feature request.

It would be nice to have the following properties from the nomination details API (/nomination/{congress}/{nominationNumber}) included in the nominee API (/nomination/{congress}/{nominationNumber}/{ordinal}):

  • introText
  • organization
  • positionTitle

e.g.

Request nomination details for 118/1906

curl 'https://api.congress.gov/v3/nomination/118/1906?format=json&api_key=<API_KEY> '

Response

{
    "nomination": {
        "actions": {
            "count": 1,
            "url": "https://api.congress.gov/v3/nomination/118/1906/actions?format=json"
        },
        "authorityDate": "2024-07-17",
        "citation": "PN1906",
        "committees": {
            "count": 1,
            "url": "https://api.congress.gov/v3/nomination/118/1906/committees?format=json"
        },
        "congress": 118,
        "isList": true,
        "latestAction": {
            "actionDate": "2024-07-08",
            "text": "Received in the Senate and referred to the Committee on Armed Services."
        },
        "nominees": [
            {
                "introText": "The following named officers for appointment in the United States Air Force to the grade indicated under title 10, U.S.C., section 624:",
                "nomineeCount": 19,
                "ordinal": 1,
                "organization": "Air Force",
                "positionTitle": "Major General",
                "url": "https://api.congress.gov/v3/nomination/118/1906/1?format=json"
            }
        ],
        "number": 1906,
        "partNumber": "00",
        "receivedDate": "2024-07-08",
        "updateDate": "2024-07-18T10:14:13Z"
    },
    "request": {
        "congress": "118",
        "contentType": "application/json",
        "format": "json",
        "number": "1906"
    }
}

Notice the nominees props:

 "nominees": [
            {
                "introText": "The following named officers for appointment in the United States Air Force to the grade indicated under title 10, U.S.C., section 624:",
                "nomineeCount": 19,
                "ordinal": 1,
                "organization": "Air Force",
                "positionTitle": "Major General",
                "url": "https://api.congress.gov/v3/nomination/118/1906/1?format=json"
            }
        ],

Request the nominees API

curl 'https://api.congress.gov/v3/nomination/118/1906/1?format=json&limit=250&offset=0&api_key=<API_KEY>' 
{
    "nominees": [
        {
            "firstName": "Frank",
            "lastName": "Verdugo",
            "middleName": "R.",
            "ordinal": 19,
            "prefix": "Brig. Gen."
        },
        {
            "firstName": "Neil",
            "lastName": "Richardson",
            "middleName": "R.",
            "ordinal": 18,
            "prefix": "Brig. Gen."
        },
		... 
    ],
    "pagination": {
        "count": 19
    },
    "request": {
        "congress": "118",
        "contentType": "application/json",
        "format": "json",
        "number": "1906"
    }
}

Suggested change to include introText, organization, positionTitle on each nominee:

{
    "nominees": [
        {
            "firstName": "Frank",
            "lastName": "Verdugo",
            "middleName": "R.",
            "ordinal": 19,
            "prefix": "Brig. Gen."
		   "introText": "The following named officers for appointment in the United States Air Force to the grade indicated under title 10, U.S.C., section 624:",
  			"organization": "Air Force",
            "positionTitle": "Major General",
        },
        {
            "firstName": "Neil",
            "lastName": "Richardson",
            "middleName": "R.",
            "ordinal": 18,
            "prefix": "Brig. Gen."
		   "introText": "The following named officers for appointment in the United States Air Force to the grade indicated under title 10, U.S.C., section 624:",
			"organization": "Air Force",
            "positionTitle": "Major General",
        },
		... 
    ],
    "pagination": {
        "count": 19
    },
    "request": {
        "congress": "118",
        "contentType": "application/json",
        "format": "json",
        "number": "1906"
    }
}
@apreiter18 apreiter18 added the enhancement New feature or request label Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants