Swift 5

[madhavajay]

Same as here:
#14

Only for Swift 5

[twairball]

I tried this branch, sure the errors go away but you broke a couple of methods and simply commented them out?

OCVImageOperation.m line 45:

+ (void)rectangleOnSource:(id<OCVInputOutputArrayable>)source fromPoint:(OCVPoint)point1 toPoint:(OCVPoint)point2 withColor:(OCVScalar)color thickness:(NSInteger)thickness lineType:(NSInteger)lineType shift:(NSInteger)shift {
#warning FIX THIS
    //cv::rectangle(*source.inputOutput._inputOutput, convertPoint(point1), convertPoint(point2), convertScalar(color), (int)thickness, (int)lineType, (int)shift);
}

and line 59:

#warning FIX THIS
    //cv::rectangle(*source.inputOutput._inputOutput, convertPoint(point1), convertPoint(point2), convertScalar(color), (int)thickness, (int)lineType, (int)shift);

[madhavajay]

@twairball I just forked the main project and didn't touch a single line of the actual LegoCV Wrapper code.

Take a look at my commit history:
https://github.com/madhavajay/LegoCV/commits/swift-5

[twairball]

Sorry, yes you're right. looks like it was from earlier commits on master.

[madhavajay]

@Legoless Do you know why the code is commented? Also there seems to be some outstanding issues that prevent usage of this library like the free memory crash with OCVMat etc.

For now I have just been bridging my own c++ code to Obj-c and its working pretty well. Its a pity since this project could really have some potential.

[Legoless]

It's incredibly hard to keep this up to date with both Swift and OpenCV changes. Swift 5 partially solves this indeed, so I will have a look at everything and continue developing the project this week. Thanks for the PR, will have a look!

[madhavajay]

@Legoless well Swift 5 promises ABI compatibility so you shouldn't have to change Swift compat again any time soon. I think the outstanding memory issues are more important as they are stopping me from even using LegoCV. But certainly it makes sense to get this project up to scratch and working. Regarding OpenCV, once the library is functioning correctly without show stopping bugs I think there would be an active community who would help keep the library up to date when things change.

[Legoless]

That is correct and I am starting to work on the project more actively again. Will keep my conversion of Swift 5, since I already did it before and will work on those fixes later this week.. Thanks for the PR though, much appreciated!