Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issues to compile and run FaceDetection demo #14

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

madhavajay
Copy link

  • Updated OpenCV submodule to 4.0.1
  • Renamed methods detectMultiscaleWith to DetectMultiScaleOnImage
  • Removed unused test targets
  • Added reference to data folder in opencv for haar cascade files
  • Updated Xcode Project to Swift Version 4.2
  • Fixed some minor project Code Deprecation changes

- Updated OpenCV submodule to 4.0.1
- Renamed methods detectMultiscaleWith to DetectMultiScaleOnImage
- Removed unused test targets
- Added reference to data folder in opencv for haar cascade files
- Updated Xcode Project to Swift Version 4.2
- Fixed some minor project Code Deprecation changes
@madhavajay
Copy link
Author

Firstly, this is an awesome project. Thanks for all the hard work!

I removed the tests because they were empty and I had trouble with OpenCV compiling for the simulator but I think it would be good to add them back and add some CI and tests. The Face Detector app wasnt compiling and now it compiles but the bounding boxes arent being drawn or something is wrong however the code is working and the Face Haar cascades work.

I want to use this with Carthage and I looked at adding a compile step into the scripts for the LegoCV target like this:

echo ${PROJECT_DIR}
opencv_framework_dir="${PROJECT_DIR}/../ios/opencv2.framework"
if [ ! -d "$opencv_framework_dir" ]
then
    echo "OpenCV framework not found at: ${opencv_framework_dir}"
    echo "Compiling OpenCV"
    /usr/bin/python ../opencv/platforms/ios/build_framework.py ../ios --dynamic
else
    echo "OpenCV framework found"
fi

But its really slow and I was thinking whats wrong with using the binaries?
Its really easy to add the official binarys using carthage and I can add this instead if you agree its a good idea?

Otherwise it would be nice to add some kind of build flag to allow building from binaries vs building from source however im not sure how that would work with Cocapods / Carthage as an extra step?

OpenCV isn't going anywhere so I think this project should be more and more popular.
I am happy to help get things into a state where they are working well and seamlessly. There seems to be some Forks with MacOS support as well so makes sense to consolidate some of these recent changes.

Thoughts?

- Removed some empty DevelopmentTeam / DEVELOPMENT_TEAM settings
@madhavajay madhavajay mentioned this pull request Apr 5, 2019
@Legoless
Copy link
Owner

Thanks for your help! It's true that OpenCV takes a while to build and at some point it should be included in the repo (git lfs would be required, as it's a huge file). Since I've already had the Swift 5 update in the work, not sure if this needs to be merged. I am keeping the test targets though, as I will be adding tests soon in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants