Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SWIPE support for physical backend #215

Merged
merged 3 commits into from
Jan 31, 2025
Merged

SWIPE support for physical backend #215

merged 3 commits into from
Jan 31, 2025

Conversation

iartemov-ledger
Copy link
Contributor

@iartemov-ledger iartemov-ledger commented Jan 29, 2025 •
edited
Loading

  • SWIPE support for physical backend
  • Fixing _actionhint element location (covered previously by the snapshot image)

@iartemov-ledger iartemov-ledger force-pushed the iar/swipe_support branch 2 times, most recently from af847bf to 6320c72 Compare January 29, 2025 17:24
@iartemov-ledger iartemov-ledger marked this pull request as ready for review January 30, 2025 08:06
lpascal-ledger
lpascal-ledger previously approved these changes Jan 31, 2025
View reviewed changes
@iartemov-ledger
Copy link
Contributor Author

iartemov-ledger commented Jan 31, 2025 •
edited
Loading

@lpascal-ledger I cannot merge automatically as "Install and test the library (3.8) " is still "Waiting for status to be reported". Is it normal ? I can merge without waiting ?

Probably normal after "Update Python version support: remove 3.8, added 3.12 and 3.13" PR ;)

@lpascal-ledger
Copy link
Contributor

@iartemov-ledger indeed it can be passed - even if I clean it on the branch protections, it will remain here.

However I just noticed you did not updated the CHANGELOG.md on your PR, could you do it please?

@lpascal-ledger lpascal-ledger self-requested a review January 31, 2025 09:17
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@iartemov-ledger
Copy link
Contributor Author

iartemov-ledger commented Jan 31, 2025 •
edited
Loading

@iartemov-ledger indeed it can be passed - even if I clean it on the branch protections, it will remain here.

However I just noticed you did not updated the CHANGELOG.md on your PR, could you do it please?

Sure @lpascal-ledger ! Done !

@iartemov-ledger iartemov-ledger merged commit 66706e8 into master Jan 31, 2025
29 checks passed
@iartemov-ledger iartemov-ledger deleted the iar/swipe_support branch January 31, 2025 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpascal-ledger lpascal-ledger lpascal-ledger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iartemov-ledger @lpascal-ledger