Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nano NBGL improvements (support Skip & truncate titles) level 22 #874

Merged
merged 2 commits into from
Feb 21, 2025

Conversation

nroggeman-ledger
Copy link
Contributor

Description

The goal of this PR is to improve Nano NBGL, to support 2 features:

  • "Skip" feature in streamed review (on demand), to be able to go directly to approval
  • Truncate title line when using multi-pages steps. If the title is greater than one line, it is truncated by it's middle (replaced by "...")

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Tests
  • Documentation
  • Other (for changes that might not fit in any category)

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (API_LEVEL_22@c73c614). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff               @@
##             API_LEVEL_22     #874   +/-   ##
===============================================
  Coverage                ?   83.02%           
===============================================
  Files                   ?        9           
  Lines                   ?      483           
  Branches                ?        0           
===============================================
  Hits                    ?      401           
  Misses                  ?       82           
  Partials                ?        0           
Flag Coverage Δ
unittests 83.02% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nroggeman-ledger nroggeman-ledger merged commit 9ca78a6 into API_LEVEL_22 Feb 21, 2025
181 checks passed
@nroggeman-ledger nroggeman-ledger deleted the nano-nbgl-improvements-22 branch February 21, 2025 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants