Modify and enrich W3C Use Cases (and related ones) #871
Conversation
nroggeman-ledger
requested review from
cedelavergne-ledger and
apaillier-ledger
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #871 +/- ##
=======================================
Coverage 60.02% 60.02%
=======================================
Files 12 12
Lines 1736 1736
=======================================
Hits 1042 1042
Misses 694 694
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| const char *reportProvider; ///< name of the security report provider, used in some strings | ||
| const char *reportUrl; ///< URL of the report, used in some strings | ||
| const char *providerMessage; ///< Dedicated provider message. Default one will be used if NULL |
There was a problem hiding this comment.
Maybe we'll need a second buffer, in the very specific cases Other risk or Other threat, where we have to display a different string between pre-transaction warning screen and security report screen?
nroggeman-ledger
force-pushed
the
web3checks-new-version
branch
from
71f0bce to
2f4d780
Compare
nroggeman-ledger
force-pushed
the
web3checks-new-version
branch
from
2f4d780 to
657ac2d
Compare
| "Web3 Checks found a risk:\n%s.", | ||
| reviewWithWarnCtx.warning->providerMessage); | ||
| bar.subText = tmpString; | ||
| bar.subText = reviewWithWarnCtx.warning->providerMessage; |
There was a problem hiding this comment.
What about (here?) to handle the "Tap the top-right icon for more details" that may appear in the 1st warning page, but should be displayed in the security report?
Could we simply check is the sentence is present and not display it here?
Or should we use 2 variables
- providerMessageScreen: for the warning screen
- providerMessageReport: for the security report
And then, if both are defined, we use them on the dedicated screen, else, usee the one defined in both screens?
Description
The goal of this PR is to modify and enrich W3C Use Cases. It also concern security reports displayed in these Use Cases, for example for Blind Signing.
Changes include
Breaking changes
nbgl_useCaseReviewWithWarning() function becomes nbgl_useCaseAdvancedReview(), because this second function was only used once in Ethereum