Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App storage functionality use simplification #69

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

iartemov-ledger
Copy link

@iartemov-ledger iartemov-ledger commented Feb 20, 2025

Based on #56 and replaces it
Blocked by LedgerHQ/ledger-secure-sdk#865 or sooner a new PR targeting master
Pair review: LedgerHQ/app-boilerplate#147

Checklist

  • No N_ variables anymore, only app_storage API
  • defines accessor macros for READ and WRITE operations
  • cached in RAM config part of storage data
  • compile-time check for the data storage size
  • backup and restore tested locally with app_storage_utils.py script (again)
  • current tests fixes:
    • Stax
    • Flex
    • NanoX
    • NanoSP
    • NanoS ?
  • New --app-storage tests (requires support in Speculos, maybe a special test app needed)
  • App update process has been followed
  • Target branch is develop
  • Application version has been bumped

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant