Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App storage use demonstrator #147

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

Conversation

iartemov-ledger
Copy link

@iartemov-ledger iartemov-ledger commented Feb 18, 2025

Based on master...app-storage
Blocked by LedgerHQ/ledger-secure-sdk#865 or sooner a new PR targeting master
Pair review: LedgerHQ/app-security-key#69

Checklist

  • No N_ variables anymore, only app_storage API
  • defines accessor macros for READ and WRITE operations
  • cached in RAM storage data use
  • compile-time check for the data storage size
  • 2 app storage versions demonstration
  • backup and restore tested locally with app_storage_utils.py script
  • current tests fixes:
    • Stax
    • Flex
    • NanoX
    • NanoSP
    • NanoS ?
  • New --app-storage tests (requires support in Speculos, maybe a special test app needed)
  • App update process has been followed
  • Target branch is develop
  • Application version has been bumped

Copy link

codecov bot commented Feb 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.46%. Comparing base (af99bcd) to head (31a21a2).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #147   +/-   ##
=======================================
  Coverage   88.46%   88.46%           
=======================================
  Files           5        5           
  Lines          78       78           
  Branches       20       20           
=======================================
  Hits           69       69           
  Misses          9        9           
Flag Coverage Δ
unittests 88.46% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants