fix: refactor to make linter happy with EigenDAConfig

Layr-Labs · Aug 9, 2024 · e80e17b · e80e17b
1 parent 5b37117
commit e80e17b
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 13 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -128,14 +128,14 @@ jobs:
       - name: Build all lint dependencies
         run: make -j build-node-deps
 
-      # - name: Lint
-      #   uses: golangci/golangci-lint-action@v3
-      #   with:
-      #     version: latest
-      #     skip-pkg-cache: true
-      # - name: Custom Lint
-      #   run: |
-      #     go run ./linters ./...
+      - name: Lint
+        uses: golangci/golangci-lint-action@v3
+        with:
+          version: latest
+          skip-pkg-cache: true
+      - name: Custom Lint
+        run: |
+          go run ./linters ./...
 
       - name: Set environment variables
         run: |

diff --git a/arbnode/node.go b/arbnode/node.go
@@ -553,7 +553,7 @@ func createNodeImpl(
 		return nil, errors.New("a data availability service is required for this chain, but it was not configured")
 	} else if config.EigenDA.Enable {
 		log.Info("EigenDA enabled")
-		eigenDAService, err := eigenda.NewEigenDA(config.EigenDA.Rpc)
+		eigenDAService, err := eigenda.NewEigenDA(&config.EigenDA)
 		if err != nil {
 			return nil, err
 		}
@@ -702,7 +702,7 @@ func createNodeImpl(
 		if daWriter != nil {
 			dapWriter = daprovider.NewWriterForDAS(daWriter)
 		}
-		
+
 		batchPoster, err = NewBatchPoster(ctx, &BatchPosterOpts{
 			DataPosterDB:  rawdb.NewTable(arbDb, storage.BatchPosterPrefix),
 			L1Reader:      l1Reader,

diff --git a/eigenda/eigenda.go b/eigenda/eigenda.go
@@ -16,7 +16,6 @@ const (
 	MaxBatchSize = 2_000_000 // 2MB
 )
 
-
 func IsEigenDAMessageHeaderByte(header byte) bool {
 	return hasBits(header, daprovider.EigenDAMessageHeaderFlag)
 }
@@ -44,8 +43,11 @@ type EigenDA struct {
 	client *EigenDAProxyClient
 }
 
-func NewEigenDA(proxyServerRpc string) (*EigenDA, error) {
-	client := NewEigenDAProxyClient(proxyServerRpc)
+func NewEigenDA(config *EigenDAConfig) (*EigenDA, error) {
+	if !config.Enable {
+		panic("EigenDA is not enabled")
+	}
+	client := NewEigenDAProxyClient(config.Rpc)
 
 	return &EigenDA{
 		client: client,