Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: reduce code duplication in anvil utils #357

Merged
merged 4 commits into from
Feb 17, 2025
Merged

refactor: reduce code duplication in anvil utils #357

merged 4 commits into from
Feb 17, 2025

Conversation

MegaRedHand
Copy link
Contributor

Fixes #

What Changed?

This PR extracts common code in start_m2_anvil_container and start_anvil_container. It also removes the mine_anvil_blocks_operator_set function, since it's no longer useful.

Reviewer Checklist

  • New features are tested and documented
  • PR updates the changelog with a description of changes
  • PR has one of the changelog-X labels (if applies)
  • Code deprecates any old functionality before removing it

@MegaRedHand MegaRedHand added the changelog-breaking [changelog] PR changes existing functionality label Feb 14, 2025
damiramirez
damiramirez approved these changes Feb 17, 2025
View reviewed changes
Copy link

@damiramirez damiramirez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MegaRedHand MegaRedHand merged commit 1628d7b into dev Feb 17, 2025
11 checks passed
@MegaRedHand MegaRedHand deleted the refactor-anvil-utils branch February 17, 2025 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablodeymo pablodeymo pablodeymo approved these changes

@damiramirez damiramirez damiramirez approved these changes

Assignees
No one assigned
Labels
changelog-breaking [changelog] PR changes existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MegaRedHand @pablodeymo @damiramirez