Skip to content

Use shorthand nullability typings for better readability #5733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: next
Choose a base branch
from

Conversation

jnoordsij
Copy link
Contributor

@jnoordsij jnoordsij commented Dec 16, 2024

WHY

BEFORE - What was wrong? What was happening before this PR?

When working on #5732, I encountered some other (nullable) types that could be simplified, to improve readability.

AFTER - What is happening after this PR?

Cleaner code.

HOW

How did you achieve that, in technical terms?

Use shorthand.

Is it a breaking change?

No (or not really); only the change in RegisterUploadEvents::handle is a change in behavior, due to no longer allowing null; however explicit null passing seems unlikely and unwanted here.

How can we test the before & after?

N/A

@pxpm
Copy link
Contributor

pxpm commented Dec 18, 2024

Hey @jnoordsij thanks for the contribution. 🙏

Would it be too much to ask to merge both PR's into a single one, since they address the same issue ?

If you don't have time/will to do it, let me know and I can do that, I'd rather merge this as a single PR 👍

Cheers

@jnoordsij
Copy link
Contributor Author

jnoordsij commented Dec 18, 2024

I'm all fine with adding the commit here to #5732. I've deliberately split them, as #5732 now only contains essential changes that are practically identical to the previous state, just solving the deprecations.

This MR goes slightly further by actually introducing a single behavior change, and thus should arguably be handled with a little more care. Moreover, the changes are merely cosmetic and are not required to actually fix deprecation messages, like #5732.

However, if you prefer handling it all together at once, just let me know and I'll cherry-pick this onto #5732.

@pxpm
Copy link
Contributor

pxpm commented Dec 19, 2024

Thanks for the clarification. 🙏

I agree then, let's merge the other PR in v6, and mark this for v7, I agree that it's unlike that anyone is using null in that parameter, but it was overlooked and to be safe we should do it in v7. We already have some BC's in internal code for uploaders in v7.

Thanks @jnoordsij 🙏

@pxpm pxpm added the v7 label Dec 19, 2024
@pxpm pxpm changed the base branch from main to next December 19, 2024 12:30
@jnoordsij jnoordsij force-pushed the null-typing-improvements branch from af9feb4 to fff82d0 Compare December 19, 2024 14:52
@jnoordsij
Copy link
Contributor Author

Sounds great! I've rebased this to resolve conflicts with the new target branch.

Also remove nullability on registerModelEvents parameter,
given that it makes little sense for a boolean value.
@jnoordsij jnoordsij force-pushed the null-typing-improvements branch from fff82d0 to 904b31e Compare March 31, 2025 14:42
@jnoordsij
Copy link
Contributor Author

jnoordsij commented Mar 31, 2025

Rebased onto next to fix conflicts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants