LibWeb: Shadow realm introduction part 3 - make HTML::Script accept a realm #1955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shannonbooth
force-pushed
the
shadow-realm-scripts
branch
4 times, most recently
from
7429b86 to
684f906
Compare
This was referenced Oct 27, 2024
shannonbooth
force-pushed
the
shadow-realm-scripts
branch
2 times, most recently
from
ebafa0a to
7878f29
Compare
Allowing us to implement other AOs in terms of this one.
To more clearly represent the host binding which a principal setting realm has.
This allows you to get the module map for any realm, whether it is a principal or synthetic realm. We don't yet have the concept of a synethetic realm, but this puts the groundwork in place for it.
This is part of a refactor needed for introduction of the shadow realm proposal in the web platform.
shannonbooth
force-pushed
the
shadow-realm-scripts
branch
from
7878f29 to
58f422f
Compare
shannonbooth
requested review from
trflynn89,
alimpfard and
AtkinsSJ
as code owners
ADKaster
approved these changes
Nov 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sitting ontop of #1932
This is the last MR / refactoring needed before introducing the concept of a 'synthetic realm' and hooking that up to [[HostDefined]].