Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a test on saving results #358

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

bowni
Copy link
Member

@bowni bowni commented Sep 14, 2021

Follow-up of PR #337 , adding a unit test to it.

@bowni bowni added help wanted Extra attention is needed optimization An optimization of something that works labels Sep 14, 2021
@bowni bowni self-assigned this Sep 14, 2021
@codecov-commenter
Copy link

codecov-commenter commented Sep 14, 2021

Codecov Report

Merging #358 (495814e) into master (eb20b80) will increase coverage by 0.26%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #358      +/-   ##
==========================================
+ Coverage   79.21%   79.48%   +0.26%     
==========================================
  Files          15       15              
  Lines        3152     3158       +6     
==========================================
+ Hits         2497     2510      +13     
+ Misses        655      648       -7     
Impacted Files Coverage Δ
mplc/dataset.py 75.67% <0.00%> (+0.11%) ⬆️
mplc/contributivity.py 76.55% <0.00%> (+1.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb20b80...495814e. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed optimization An optimization of something that works
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants