Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use refind for Nav Bar items #2245

Merged
merged 3 commits into from
Jan 31, 2025
Merged

Use refind for Nav Bar items #2245

merged 3 commits into from
Jan 31, 2025

Conversation

labkey-danield
Copy link
Contributor

@labkey-danield labkey-danield commented Jan 27, 2025

Rationale

Addressing occasional stale element failures with nav bar.

Related Pull Requests

Changes

  • Use refind for elements on the NavBar, they may reload with a navigation.

…ion.

Add logging to the OverviewPage.getLineagePanelGrid.
Add a check in SampleTypeDesignPage.beginAt to wait for any spinners to go away.
In SMSampleNameIsRowIdTest.testSetLineageFromGrid check that update was successful before moving on.
@labkey-danield labkey-danield requested review from a team and labkey-chrisj and removed request for a team January 27, 2025 18:53
Copy link
Contributor

@labkey-chrisj labkey-chrisj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Thanks for doing this!

@labkey-danield labkey-danield merged commit 22738fd into develop Jan 31, 2025
2 checks passed
@labkey-danield labkey-danield deleted the fb_smTestFixes branch January 31, 2025 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants