Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 52038: Fix problems fields whose names and fieldKeys are different #2243

Merged
merged 7 commits into from
Jan 27, 2025
Merged

Issue 52038: Fix problems fields whose names and fieldKeys are different #2243

merged 7 commits into from
Jan 27, 2025

Conversation

labkey-susanh
Copy link
Contributor

Rationale

Issue 52038

Related Pull Requests

Changes

  • Add constants for some sets of characters that are tricky in one way or another
  • Add utility methods in TestFileUtils for quoting header strings for tsv and csv files when necessary

labkey-tchad
labkey-tchad reviewed Jan 27, 2025
View reviewed changes
Copy link
Member

@labkey-tchad labkey-tchad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this use TestDataUtils.TsvQuoter?

@labkey-susanh
Copy link
Contributor Author

Could this use TestDataUtils.TsvQuoter?

Yes, probably so. I didn't know that existed. In the interest of time, I'll add a TODO instead of making that change right now, though.

@labkey-susanh labkey-susanh merged commit 0bb5eef into release24.11-SNAPSHOT Jan 27, 2025
1 of 2 checks passed
@labkey-susanh labkey-susanh deleted the 24.11_fb_fieldKeyConfusion branch January 27, 2025 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@labkey-tchad labkey-tchad labkey-tchad left review comments

@labkey-danield labkey-danield labkey-danield approved these changes

@cnathe cnathe Awaiting requested review from cnathe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@labkey-susanh @labkey-tchad @labkey-danield @cnathe