Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Selenium 4.13.0 #2205

Merged
merged 1 commit into from
Dec 20, 2024
Merged

Conversation

labkey-tchad
Copy link
Member

@labkey-tchad labkey-tchad commented Dec 19, 2024

Rationale

Our new Windows agent AMI doesn't have geckodriver preinstalled. Selenium should be able to download it automatically as of v4.6. It didn't download successfully.

Caused by: org.openqa.selenium.remote.NoSuchDriverException: geckodriver located at C:\Windows\system32\config\systemprofile\.cache\selenium\geckodriver\win64\0.35.0\geckodriver.exe, but invalid
For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors/driver_location/
Build info: version: '4.11.0', revision: '040bc5406b'
System info: os.name: 'Windows Server 2022', os.arch: 'amd64', os.version: '10.0', java.version: '17.0.7'
Driver info: driver.version: BaseWebDriverTest$SingletonWebDriver
  at app//org.openqa.selenium.remote.service.DriverFinder.getPath(DriverFinder.java:45)
  at app//org.openqa.selenium.remote.service.DriverFinder.getPath(DriverFinder.java:13)
  at app//org.openqa.selenium.firefox.FirefoxDriver.generateExecutor(FirefoxDriver.java:141)
  at app//org.openqa.selenium.firefox.FirefoxDriver.<init>(FirefoxDriver.java:132)
  at app//org.openqa.selenium.firefox.FirefoxDriver.<init>(FirefoxDriver.java:127)
  at app//org.labkey.test.WebDriverWrapper.createNewWebDriver(WebDriverWrapper.java:380)
  ... 9 more

Updating to Selenium 4.13 seems to fix it without introducing any problems with existing tests (4.14+ required more significant refactors when we made that update in 24.4).

Related Pull Requests

  • N/A

Changes

  • Update to Selenium 4.13.0

Try to make automatic geckodriver download work on TeamCity
@labkey-tchad labkey-tchad self-assigned this Dec 19, 2024
@labkey-tchad
Copy link
Member Author

Verifying with the ONPRC suite since that's the primary thing we care about in that release.

@labkey-tchad labkey-tchad merged commit 01f0c72 into release23.11-SNAPSHOT Dec 20, 2024
3 of 4 checks passed
@labkey-tchad labkey-tchad deleted the 23.11_fb_selenium4.13 branch December 20, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants