Change locators for additional format elements #2186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
labkey-danield
requested review from
a team and
labkey-tchad
and removed request for
a team
labkey-tchad
requested changes
Dec 10, 2024
There was a problem hiding this comment.
This class should extend BaseSettingsPage. That class received a similar fix last week.
admin-lookAndFeelSettings.view, admin-projectSettings.view, and admin-folderSettings.view all come from lookAndFeelProperties.jsp. The first two already have page classes that extend BaseSettingsPage. (SiteValidationPage also extends it but I think that was done in error)
labkey-tchad
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Additional parsing formats are only available is the deprecated / optional feature is enabled. Locators for those elements needs to take that into account.
Related Pull Requests
Changes