Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decode reportId to avoid double-encoding later #2182

Merged
merged 2 commits into from
Dec 9, 2024
Merged

Decode reportId to avoid double-encoding later #2182

merged 2 commits into from
Dec 9, 2024

Conversation

labkey-tchad
Copy link
Member

Rationale

ScriptReportPage.saveReport should decode the reportId parameter so that it is compatible with the encoding behavior of ScriptReportPage.beginAtReport.

Related Pull Requests

Changes

  • Decode reportId to avoid double-encoding by beginAtReport

@labkey-tchad labkey-tchad merged commit ad25c17 into develop Dec 9, 2024
4 checks passed
@labkey-tchad labkey-tchad deleted the fb_decodingParameters branch December 9, 2024 21:40
@labkey-tchad labkey-tchad mentioned this pull request Dec 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@labkey-sweta labkey-sweta labkey-sweta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@labkey-tchad @labkey-sweta