Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Hardcoded Time Zones #2181

Merged
merged 4 commits into from
Dec 11, 2024
Merged

Fix Hardcoded Time Zones #2181

merged 4 commits into from
Dec 11, 2024

Conversation

labkey-danield
Copy link
Contributor

@labkey-danield labkey-danield commented Dec 9, 2024 •
edited
Loading

Rationale

Test shouldn't assume a timezone. (TeamCity failure)

Tests are passing in 24.12:
Postgres
Windows / MSSQL

Related Pull Requests

  • None

Changes

  • Get the timezone.
  • Use appropriate timezone for different test dates.
  • Special case windows not showing zulu time.

@labkey-danield labkey-danield requested review from a team and labkey-sweta and removed request for a team December 10, 2024 23:57
@labkey-danield labkey-danield merged commit e07db68 into release24.11-SNAPSHOT Dec 11, 2024
3 checks passed
@labkey-danield labkey-danield deleted the 24.11_fb_testTimeZoneFixes branch December 11, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@labkey-sweta labkey-sweta labkey-sweta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@labkey-danield @labkey-sweta