Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Various Test Issue #2126

Merged
merged 14 commits into from
Nov 11, 2024

Conversation

labkey-danield
Copy link
Contributor

@labkey-danield labkey-danield commented Nov 5, 2024

Rationale

Fixing various test issues.

Related Pull Requests

Changes

  • Change DetailTableEdit.DetailDataPanel to wait for the button to go stale. The button is a more reliable check. A spinner may be slow to show up, and the tests never sees it. If a spinner does show up the button won't go away until the spinner does.
  • Update ApiKeyDialog.getClipboardContent. This fails on WIndows with an 'unknown MIME type' error. This adds more logging and validates that as long as the clipboard isn't empty it will return a value. It returns an empty string if there is nothing in the clipboard.
  • Remove getEditableRowIndices, getReadonlyRowIndices & getRowTypes from EditableGrid. These methods were initially added to accommodate the editable grid in the inventory module. In previous UI designs when adding or moving samples in storage the editable grid would be a mix of editable and non-editable rows (indicating positions already occupied). That is no longer the design, and these methods were adding no value.
  • Updated EntityInsertPanel to accommodate the removed methods from the editable grid.

@labkey-danield labkey-danield merged commit f29bbdb into release24.11-SNAPSHOT Nov 11, 2024
1 of 2 checks passed
@labkey-danield labkey-danield deleted the 24.11_fb_smVariousTestIssue branch November 11, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants