Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Escape the space in the study name. #2123

Merged
merged 2 commits into from
Nov 5, 2024
Merged

Escape the space in the study name. #2123

merged 2 commits into from
Nov 5, 2024

Conversation

labkey-danield
Copy link
Contributor

Rationale

Escape the space used in the study name.

Related Pull Requests

Changes

  • Replace space with %20

@labkey-danield labkey-danield mentioned this pull request Nov 5, 2024
Merged
labkey-jeckels
labkey-jeckels approved these changes Nov 5, 2024
View reviewed changes
Copy link
Contributor

@labkey-jeckels labkey-jeckels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider using FileBrowserHelper.encodeFileNodeIdPart()

@labkey-danield
Copy link
Contributor Author

FileBrowserHelper.encodeFileNodeIdPart()

Updated fix to use FileBrowserHelper.

@labkey-danield labkey-danield merged commit 4ed39df into develop Nov 5, 2024
2 checks passed
@labkey-danield labkey-danield deleted the fb_escapeStudyName branch November 5, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@labkey-jeckels labkey-jeckels labkey-jeckels approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@labkey-danield @labkey-jeckels