Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected definition of Time column type. #1910

Merged
merged 1 commit into from
May 2, 2024

Conversation

labkey-danield
Copy link
Contributor

@labkey-danield labkey-danield commented May 1, 2024

Rationale

Use correct definition for Time column type.
Issue 50238: Using CreateDomianCommand to create a sample type with a Time-only field results in a bad picker for the field.

@XingY: This is just an FYI for you.

Related Pull Requests

  • None

Changes

  • Changed parameter passed into ColumnTypeImpl for the Time column type.

@labkey-danield labkey-danield requested review from a team, labkey-tchad and XingY and removed request for a team May 1, 2024 05:09
Copy link
Member

@labkey-tchad labkey-tchad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you verified that this change fixes the problem? When I was investigating this, domains created via API and via UI both had the full 'rangeURI' in the getDomain response.

@labkey-danield
Copy link
Contributor Author

labkey-danield commented May 1, 2024

@labkey-tchad yes I validated using the small sample test code in the issue. It creates a sample type by:

        FMSampleTypeDefinition stDefinition = new FMSampleTypeDefinition(stName);
        stDefinition.setInventoryMetricUnit(InventoryMetricUnit.ML);
        stDefinition.setFields(List.of(
                new FieldDefinition(COL_DATETIME_CAPTION, FieldDefinition.ColumnType.DateAndTime),
                new FieldDefinition(COL_DATE_CAPTION, FieldDefinition.ColumnType.Date),
                new FieldDefinition(COL_TIME_CAPTION, FieldDefinition.ColumnType.Time)
        ));

        SampleTypeAPIHelper.createEmptySampleType(getProjectName(), stDefinition);

It then uses the time picker to select the time in a bulk edit/update dialog.
I also validated manually in the editable grid with the same sample type that the time picker is correct.

I also validated that running the test with out this change fails as per the issue.

@labkey-danield labkey-danield merged commit 6daaeb4 into develop May 2, 2024
5 checks passed
@labkey-danield labkey-danield deleted the fb_testFixTimeColumnType branch May 2, 2024 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants