Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve-cross project actions - Edit in Bulk #1904

Merged
merged 3 commits into from
Apr 29, 2024
Merged

Improve-cross project actions - Edit in Bulk #1904

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2d4e793
EntityBulkUpdateDialog params for "columnTitle" confusing when really…
cnathe Apr 24, 2024
16ef351
Merge branch 'develop' into fb_crossFolderEditInBulk
cnathe Apr 25, 2024
16ffe9d
Merge branch 'develop' into fb_crossFolderEditInBulk
cnathe Apr 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions src/org/labkey/test/components/ui/entities/EntityBulkUpdateDialog.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,14 +41,14 @@ public EntityBulkUpdateDialog(WebDriver driver, UpdatingComponent updatingCompon

// enable/disable field editable state

public boolean isFieldEnabled(String columnTitle)
public boolean isFieldEnabled(String fieldKey)
{
return elementCache().getToggle(columnTitle).isOn();
return elementCache().getToggle(fieldKey).isOn();
}

public EntityBulkUpdateDialog setEditableState(String columnTitle, boolean enable)
public EntityBulkUpdateDialog setEditableState(String fieldKey, boolean enable)
{
elementCache().getToggle(columnTitle).set(enable);
elementCache().getToggle(fieldKey).set(enable);
return this;
}

Expand All @@ -59,12 +59,12 @@ private WebDriverWait waiter()

// interact with selection fields

public EntityBulkUpdateDialog setSelectionField(String columnTitle, List<String> selectValues)
public EntityBulkUpdateDialog setSelectionField(String fieldKey, List<String> selectValues)
{
setEditableState(columnTitle, true);
FilteringReactSelect reactSelect = elementCache().getSelect(columnTitle);
setEditableState(fieldKey, true);
FilteringReactSelect reactSelect = elementCache().getSelect(fieldKey);
WebDriverWrapper.waitFor(reactSelect::isEnabled,
"the ["+columnTitle+"] reactSelect did not become enabled in time", WAIT_TIMEOUT);
"the ["+fieldKey+"] reactSelect did not become enabled in time", WAIT_TIMEOUT);
selectValues.forEach(reactSelect::filterSelect);
return this;
}
Expand Down